WIP: qt5.qtwebengine: Fix darwin build #40149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
|
@matthewbauer Tried to fix qtwebengine on darwin. It's still compiling, but passed the previous problems, so I'm optimistic this builds. |
Mic92
reviewed
May 8, 2018
| @@ -24,8 +25,9 @@ qtModule { | |||
| name = "qtwebengine"; | |||
| qtInputs = [ qtdeclarative qtquickcontrols qtlocation qtwebchannel ]; | |||
| nativeBuildInputs = [ | |||
| bison coreutils flex git gperf ninja pkgconfig python2 which gn | |||
| bison coreutils flex git gperf ninja pkgconfig python2 which gn xcbuild | |||
There was a problem hiding this comment.
Fixed. Thanks for the review.
knedlsepp
force-pushed
the
fix-qtwebengine-on-darwin
branch
from
46f12b8
to
7dabe46
Compare
knedlsepp
changed the title
knedlsepp
commented
May 8, 2018
| @@ -176,6 +183,12 @@ EOF | |||
| Prefix = .. | |||
| EOF | |||
| paxmark m $out/libexec/QtWebEngineProcess | |||
| '' + '' | |||
There was a problem hiding this comment.
@Mic92 What do you think about this? Should it also be darwin only? Currently the build succeeds incorrectly on darwin, but it might also on linux: https://hydra.nixos.org/build/73282201/log
|
Did it build in the end? |
|
I couldn't finish the build yesterday. (Linux build https://hydra.nixos.org/build/73282040 takes over 9 hours). I will only be able to resume the build tonight. |
|
It actually didn't go through. |
|
Ok well that's getting closer. It's an issue with Chromium using Apple's proprietary OpenBSM. I just pushed a commit that hopefully fixes it. |
|
How did you come up with that? |
|
From this: darlinghq/darling-bsm@a0c5782 I have no idea if it's right but it compiles! |
|
@GrahamcOfBorg build qt5.qtwebengine |
|
Failure on x86_64-darwin (full log) Attempted: qt5.qtwebengine Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qt5.qtwebengine Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: qt5.qtwebengine Partial log (click to expand)
|
|
Oddly enough it's the same issue again: Are the |
|
Yeah we might need to just go back to patching it. Try reverting my commit & adding one for the file that needs it. Hopefully there are not too many more cases. They're supposed to be used for everything that uses stdenv's compiler. Not sure what's going on here- it may be picking up /usr/bin/gcc somehow. |
|
@GrahamcOfBorg build qt5.qtwebengine Ok patch applied in 79dcdce |
|
Failure on x86_64-darwin (full log) Attempted: qt5.qtwebengine Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: qt5.qtwebengine Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qt5.qtwebengine Partial log (click to expand)
|
|
I guess we need something along those lines: |
This prevents the build falsely succeeding, despite generating no files. See e.g. https://hydra.nixos.org/build/73282535
The build failed with the following error before: ``` Could not resolve SDK product version for 'macosx'. Building Qt WebEngine requires a macOS SDK version of 10.11 or newer. Current version is . QtWebEngine will not be built. ```
The build failed with the following error before: ``` Could not resolve SDK product version for 'macosx'. Building Qt WebEngine requires a macOS SDK version of 10.11 or newer. Current version is . QtWebEngine will not be built. ```
Chromium’s sandbox uses some proprietary apple features. I’ve added a CPP function to substitute the relevant info.
knedlsepp
force-pushed
the
fix-qtwebengine-on-darwin
branch
from
7e1edfe
to
b53c46b
Compare
|
Now it's stuck on: |
GrahamcOfBorg
added
10.rebuild-darwin: 101-500
and removed
10.rebuild-darwin: 11-100
labels
knedlsepp
force-pushed
the
fix-qtwebengine-on-darwin
branch
from
59e168a
to
76e57dd
Compare
|
Is there any update? Does this work now? |
|
It seems I got ahead of myself with this PR; This is sadly still only WIP. |
|
(triage) @knedlsepp, are you still working on this? |
|
Not at the moment, sry. I'm gonna close this for now until I find time to actually fix it. |
veprbl
added a commit
to asymmetric/nixpkgs
that referenced
this pull request
Jan 6, 2019
Runtime doesn't work: ModuleNotFoundError: No module named 'PyQt5.QtWebEngineWidgets' This is probably because qtwebengine is broken on darwin, but doesn't fail the build (NixOS#40149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes issue: #36932
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)