Fix background color for dark themes #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We shouldn't reduce contrast unneccesarily. What do you mean by "dark theme"? If you're using custom css then that's your compatibility to solve, not ours. |
|
It's actually good practice when specifying a foreground color to also define the background color instead of relying on a default. It should be |
|
I've chosen a light grey, but whatever light color including white will fix this. I use a dark theme on my desktop, and my browser use it too. The default background color depends on this, and for me its a dark one. Most use default light themes, that's why the background color when not set is light for them. |
j8r
changed the title
For browsers using a dark theme, the dark text was on a dark background
RX14
approved these changes
May 8, 2018
sdogruyol
approved these changes
May 8, 2018
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
For browsers using a dark theme, the dark text was on a dark background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For browsers using a dark theme, the dark text was on a dark background.
Now the background is a very light grey for every browsers.