Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: liblgvnd fix for libGL.so in libpath #40150

Merged
merged 1 commit into from May 9, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented May 7, 2018

Motivation for this change

libglvnd change caused libGL.so to not be found.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: zoom-us

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: zoom-us

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: zoom-us

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@xeji xeji merged commit 5720c05 into NixOS:master May 9, 2018
@danbst
Copy link
Contributor

danbst commented May 21, 2018

@srhb Note that there was previously some problem with Nvidia drivers, due to which mesa was removed from LD_LIBRARY_PATH

#26916

You now reintroduce libGL there - wouldn't that trigger similar problems?

CCing @cstrahan

@srhb
Copy link
Contributor Author

srhb commented May 21, 2018

@danbst I don't think so, but I can try to check later today, I happen to have an nvidia card.

@srhb
Copy link
Contributor Author

srhb commented May 21, 2018

@danbst Got a moment to spare to reboot a few times. :)

Tested on NixOS unstable a480887:

  • videoDrivers = [ "intel" ] firmware set to integrated only: Works
  • videoDrivers = [ "nvidia" ] firmware set to discrete only: Works
  • videoDrivers = [ "intel" ] firmware set to optimus: Works with and without bumblebee.

Note that the glvnd changes meant that zoom did not work in either case on master. That said, there might be a better way to add them than what I currently did, suggestions welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants