Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libu2f-server: 1.0.1 -> 1.1.0 #40138

Merged
merged 1 commit into from May 7, 2018
Merged

libu2f-server: 1.0.1 -> 1.1.0 #40138

merged 1 commit into from May 7, 2018

Conversation

helinko
Copy link
Contributor

@helinko helinko commented May 7, 2018

Motivation for this change

Simple upgrade, also the previous version is broken at least with pam_u2f (see issues 1 and 2)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @philandstuff

@xeji
Copy link
Contributor

xeji commented May 7, 2018

@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented May 7, 2018

@GrahamcOfBorg build libu2f-server pam_u2f

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libu2f-server, pam_u2f

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6
shrinking /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6/bin/pamu2fcfg
shrinking /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6/lib/security/pam_u2f.so
gzipping man pages under /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6/lib  /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6/bin
patching script interpreter paths in /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6
checking for references to /build in /nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6...
/nix/store/06nc07vdvq1s2rmvd3lcffw09v391i4v-libu2f-server-1.1.0
/nix/store/060b4y11qfvx26lxnzll5yj8ifcvkkwz-pam_u2f-1.0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libu2f-server, pam_u2f

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6
shrinking /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6/bin/pamu2fcfg
shrinking /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6/lib/security/pam_u2f.so
gzipping man pages under /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6/lib  /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6/bin
patching script interpreter paths in /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6
checking for references to /build in /nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6...
/nix/store/q9cb83c73c30bsg2ajnxxhy872h84zjl-libu2f-server-1.1.0
/nix/store/0ayrrr8fmqmvzcbvy1qqlrxqj541fsrr-pam_u2f-1.0.6

@xeji xeji merged commit 17fe52a into NixOS:master May 7, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libu2f-server, pam_u2f

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philandstuff philandstuff philandstuff approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@helinko @xeji @GrahamcOfBorg @philandstuff @Janik-Haag