Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3lock/i3lock-color: meta: improve description #40142

Merged
merged 1 commit into from May 8, 2018
Merged

i3lock/i3lock-color: meta: improve description #40142

merged 1 commit into from May 8, 2018

Conversation

rkoe
Copy link
Contributor

@rkoe rkoe commented May 7, 2018

Motivation for this change

i3lock-color currently has the exactly same description as i3lock; and both do not have a long description, so:

  • i3lock-color: extend description to differ from i3lock
  • i3lock/i3lock-color: add long description (so you know what it does before installing it)
  • i3lock-color: fix homepage to point to the i3lock-color-github-page
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @garbas @malyn

@rkoe
i3lock/i3lock-color: meta: improve description
4ee409a 
- i3lock-color: extend description to differ from i3lock
- i3lock/i3lock-color: add long description
davidak
davidak approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@xeji
Copy link
Contributor

xeji commented May 8, 2018

@GrahamcOfBorg build i3lock i3lock-color

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: i3lock, i3lock-color

Partial log (click to expand)

these paths will be fetched (0.07 MiB download, 0.24 MiB unpacked):
  /nix/store/bcwc9z9c9pva3h5y7ldxlm2icid82xy2-i3lock-color-2.11-c
copying path '/nix/store/bcwc9z9c9pva3h5y7ldxlm2icid82xy2-i3lock-color-2.11-c' from 'https://cache.nixos.org'...
/nix/store/9bldr18i3qdwipgmhiig0clzcvi1rprc-i3lock-2.10
/nix/store/bcwc9z9c9pva3h5y7ldxlm2icid82xy2-i3lock-color-2.11-c

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: i3lock

The following builds were skipped because they don't evaluate on aarch64-linux: i3lock-color

Partial log (click to expand)


b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


these paths will be fetched (0.02 MiB download, 0.06 MiB unpacked):
  /nix/store/8jfwbcjbx45kff7vvb8ivwfv5ipsrkib-i3lock-2.10
copying path '/nix/store/8jfwbcjbx45kff7vvb8ivwfv5ipsrkib-i3lock-2.10' from 'https://cache.nixos.org'...
/nix/store/8jfwbcjbx45kff7vvb8ivwfv5ipsrkib-i3lock-2.10

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: i3lock, i3lock-color

Partial log (click to expand)

    ^~~~
    int
1 warning and 3 errors generated.
make[2]: *** [Makefile:683: i3lock-jpg.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-i3lock-color-2.11-c.drv-0/source/x86_64-apple-darwin16.3.0'
make[1]: *** [Makefile:444: all] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-i3lock-color-2.11-c.drv-0/source/x86_64-apple-darwin16.3.0'
make: *** [Makefile:426: all] Error 2
builder for '/nix/store/2s3srxyxjw0wxjfpnxjzjyhmj6ybjqgh-i3lock-color-2.11-c.drv' failed with exit code 2
error: build of '/nix/store/2s3srxyxjw0wxjfpnxjzjyhmj6ybjqgh-i3lock-color-2.11-c.drv' failed

@xeji
Copy link
Contributor

xeji commented May 8, 2018

darwin build failed before this PR.

@xeji xeji merged commit c53e3d2 into NixOS:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rkoe @xeji @GrahamcOfBorg @davidak