Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: Put back isArm, with deprecation notice. #40154

Merged
merged 1 commit into from May 8, 2018
Merged

stdenv: Put back isArm, with deprecation notice. #40154

merged 1 commit into from May 8, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

This was always meant to be deprecated rather than removed.

Does it solve you problem, @dezgeg?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
stdenv: Put back isArm, with deprecation notice.
302c4c5 
This was always meant to be deprecated rather than removed.
@Ericson2314 Ericson2314 requested a review from dezgeg May 8, 2018 00:15
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: stdenv Standard environment label May 8, 2018
@Ericson2314 Ericson2314 mentioned this pull request May 8, 2018
Merged
8 tasks
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: stdenv

Partial log (click to expand)

/nix/store/3y0wxpkxzs6yz73iw35d17qr1wp4p2i4-stdenv-linux

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: stdenv

Partial log (click to expand)

/nix/store/8sd7p53snnl8iszbif15mkax2mivj424-stdenv-linux

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: stdenv

Partial log (click to expand)

  /nix/store/l1d4iaik29pkg7pdng7iw8ch75h71n36-patch-2.7.6
copying path '/nix/store/1c995fhi4rqn7ss7qv4l5mbcl5ajyspf-adv_cmds-osx-10.5.8-locale' from 'https://cache.nixos.org'...
copying path '/nix/store/4m83wvzmqmwsxbzcxrb06lf72ankmm4g-ed-1.14.2' from 'https://cache.nixos.org'...
copying path '/nix/store/4az8fqi87afk9b910gan6z171k6lwqfa-binutils-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/l1d4iaik29pkg7pdng7iw8ch75h71n36-patch-2.7.6' from 'https://cache.nixos.org'...
copying path '/nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin' from 'https://cache.nixos.org'...
copying path '/nix/store/jxmp27m26646f67faji9v94d5471ma8y-cctools-binutils-darwin-wrapper' from 'https://cache.nixos.org'...
copying path '/nix/store/8b0gj3bmcy5bh1zcnhn0146199b3m5kb-clang-wrapper-5.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/dr80a9mwy52yqaxc9n9lw35mqm4yc08p-stdenv-darwin' from 'https://cache.nixos.org'...
/nix/store/dr80a9mwy52yqaxc9n9lw35mqm4yc08p-stdenv-darwin

@Ericson2314 Ericson2314 merged commit 5bdfe37 into NixOS:master May 8, 2018
@Ericson2314 Ericson2314 deleted the stdenv-arm-alias branch May 8, 2018 18:25
@Ericson2314 Ericson2314 restored the stdenv-arm-alias branch May 8, 2018 18:25
@Ericson2314 Ericson2314 mentioned this pull request May 8, 2018
Merged
8 tasks
Ericson2314 added a commit that referenced this pull request May 8, 2018
@Ericson2314
Merge pull request #40185 from obsidiansystems/stdenv-arm-alias
9746c1a 
stdenv: Put back isArm, with deprecation notice.

Back-port of #40154
@Ericson2314 Ericson2314 deleted the stdenv-arm-alias branch May 8, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg