Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-fuzz: init at 0.5.3 #40159

Merged
merged 1 commit into from May 8, 2018
Merged

cargo-fuzz: init at 0.5.3 #40159

merged 1 commit into from May 8, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented May 8, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cargo-fuzz

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/.fingerprint'
cp: -r not specified; omitting directory 'target/release/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wv3k53qbyfp476a5jpzi91h71y7yfdh1-cargo-fuzz-0.5.3
shrinking /nix/store/wv3k53qbyfp476a5jpzi91h71y7yfdh1-cargo-fuzz-0.5.3/bin/cargo-fuzz
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wv3k53qbyfp476a5jpzi91h71y7yfdh1-cargo-fuzz-0.5.3/bin
patching script interpreter paths in /nix/store/wv3k53qbyfp476a5jpzi91h71y7yfdh1-cargo-fuzz-0.5.3
checking for references to /build in /nix/store/wv3k53qbyfp476a5jpzi91h71y7yfdh1-cargo-fuzz-0.5.3...
/nix/store/wv3k53qbyfp476a5jpzi91h71y7yfdh1-cargo-fuzz-0.5.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo-fuzz

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/13m07df1laxg78wds1h9jvh2s8bk6gn1-cargo-fuzz-0.5.3
shrinking /nix/store/13m07df1laxg78wds1h9jvh2s8bk6gn1-cargo-fuzz-0.5.3/bin/cargo-fuzz
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/13m07df1laxg78wds1h9jvh2s8bk6gn1-cargo-fuzz-0.5.3/bin
patching script interpreter paths in /nix/store/13m07df1laxg78wds1h9jvh2s8bk6gn1-cargo-fuzz-0.5.3
checking for references to /build in /nix/store/13m07df1laxg78wds1h9jvh2s8bk6gn1-cargo-fuzz-0.5.3...
/nix/store/13m07df1laxg78wds1h9jvh2s8bk6gn1-cargo-fuzz-0.5.3

Mic92
Mic92 reviewed May 8, 2018
View reviewed changes
pkgs/development/tools/rust/cargo-fuzz/default.nix
rev = version;
sha256 = "1l452fnjw7i10nrd4y4rssi5d457vgjp6rhdr9cnq32bjhdkprrs";
};
cargo-lock = fetchurl {
Copy link
Member

@Mic92 Mic92 May 8, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add a simple comment like: Run cargo build in the project source to generate a new Cargo.lock file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, since it is fixed in the next version anyway, it should be ok.

@Mic92 Mic92 merged commit b1c467a into NixOS:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @Mic92