Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adr-tools: init at 2.1.0 #39014

Closed
wants to merge 1 commit into from
Closed

adr-tools: init at 2.1.0 #39014

wants to merge 1 commit into from

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Apr 16, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Apr 17, 2018

@GrahamcOfBorg build adr-tools

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: adr-tools

Partial log (click to expand)

TEST: must-provide-a-title-when-creating-new-adr
if adr new							if adr new
then								then
    echo ERROR: should have failed				    echo ERROR: should have failed
fi								fi
/build/source/tests/must-provide-a-title-when-creating-new-ad |	ERROR: no title given
make: *** [Makefile:9: build/tests/must-provide-a-title-when-creating-new-adr.diff] Error 1
make: *** Deleting file 'build/tests/must-provide-a-title-when-creating-new-adr.diff'
builder for '/nix/store/xb0fz7q00a6lkxdlflp95v3dvd8k4ci3-adr-tools-2.1.0.drv' failed with exit code 2
error: build of '/nix/store/xb0fz7q00a6lkxdlflp95v3dvd8k4ci3-adr-tools-2.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: adr-tools

Partial log (click to expand)

ls .
/build/source/tests/alternative-adr-directory.sh: line 4: ls: not found
ls alternative-dir
/build/source/tests/alternative-adr-directory.sh: line 5: ls: not found

adr list
/build/source/tests/alternative-adr-directory.sh: line 7: adr: not found
make: *** [Makefile:15: build/tests/alternative-adr-directory.output] Error 1
builder for '/nix/store/zlh7ghfb407f7kxid9lm2nar8avc6n64-adr-tools-2.1.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/zlh7ghfb407f7kxid9lm2nar8avc6n64-adr-tools-2.1.0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Apr 21, 2018

I have the same failure here.

@matthewbauer
Copy link
Member

I think we also want ADR to have its own install phase. We don’t want .md files in the bin directory.

matthewbauer
matthewbauer requested changes Apr 28, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve build issues

@mbode mbode closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbode @nlewo @GrahamcOfBorg @Mic92 @matthewbauer