Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: 2.2.8 -> 3.0.1 WIP #39037

Closed
wants to merge 3 commits into from
Closed

vlc: 2.2.8 -> 3.0.1 WIP #39037

wants to merge 3 commits into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Also drop the qt4 variant as qt4 is unsupported and fix up the live555 to actually be usable by vlc.

Please note that running vlc spews out a ton of warnings about the plugins cache which I haven't figured out how to deal with but it runs normally anyway.

Haven't run nox-review yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg mentioned this pull request Apr 17, 2018
Closed
8 tasks
@peterhoeg peterhoeg changed the title vlc: 2.2.6 -> 3.0.1 WIP vlc: 2.2.8 -> 3.0.1 WIP Apr 17, 2018
@peterhoeg
live555: 2018-02-12 -> 2018-02-28
e956f22 
Additionally, we weren't building dynamic libraries so the only consumer (vlc)
was then unable to use this for anything anyway.

A few other cleanups.
@matthewbauer matthewbauer mentioned this pull request Apr 20, 2018
Merged
8 tasks
@ghost ghost mentioned this pull request Apr 22, 2018
Closed
@peterhoeg
Copy link
Member Author

Closed due to earlier PR.

@peterhoeg peterhoeg closed this Apr 25, 2018
@peterhoeg peterhoeg deleted the u/vlc branch June 6, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @matthewbauer @GrahamcOfBorg