Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.django: 1.11.9 -> 1.11.12 #39047

Merged
merged 1 commit into from Apr 17, 2018
Merged

Conversation

lsix
Copy link
Member

@lsix lsix commented Apr 17, 2018

Once merged, I’ll backport this to release-18.03.

Some derivations that needs django failes to build before and after this update.

Motivation for this change

Release notes and associated fixed CVEs:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -7,13 +7,13 @@
buildPythonPackage rec {
pname = "Django";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop that line?

@lsix
Copy link
Member Author

lsix commented Apr 17, 2018

@dotlambda done.

@dotlambda
Copy link
Member

I fixed the url (${pname}-${version} instead of ${name}).

@dotlambda dotlambda merged commit fcbee75 into NixOS:master Apr 17, 2018
@lsix
Copy link
Member Author

lsix commented Apr 17, 2018

@dotlambda thanks. I missed it.

@lsix lsix deleted the django_1_11_12 branch August 22, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants