Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cantata: build with vlc_qt5 #39020

Closed
wants to merge 1 commit into from
Closed

cantata: build with vlc_qt5 #39020

wants to merge 1 commit into from

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Apr 16, 2018

Motivation for this change

Get rid of qt4 from cantata's closure.

/cc @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cantata

Partial log (click to expand)

libtool: install: /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c .libs/libstream_out_mosaic_bridge_plugin.lai /nix/store/a5plz0p5wz8352h6cbqr497y4rn3p2rc-vlc-2.2.8/lib/vlc/plugins/stream_out/libstream_out_mosaic_bridge_plugin.la
libtool: install: warning: relinking `libstream_out_autodel_plugin.la'
libtool: install: (cd /build/vlc-2.2.8/modules/stream_out; /nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash /build/vlc-2.2.8/modules/stream_out/../../libtool  --silent --tag CC --mode=relink gcc -g -O2 -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -O4 -fno-math-errno -funsafe-math-optimizations -fno-rounding-math -fno-signaling-nans -fcx-limited-range -funroll-loops -fomit-frame-pointer -avoid-version -module -export-symbols-regex "^vlc_entry" -shrext .so -no-undefined ../../compat/libcompat.la ../../src/libvlccore.la -rpath /nix/store/a5plz0p5wz8352h6cbqr497y4rn3p2rc-vlc-2.2.8/lib/vlc/plugins/stream_out -o libstream_out_autodel_plugin.la -rpath /nix/store/a5plz0p5wz8352h6cbqr497y4rn3p2rc-vlc-2.2.8/lib/vlc/plugins/stream_out libstream_out_autodel_plugin_la-autodel.lo )
libtool: install: /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c .libs/libstream_out_autodel_plugin.soT /nix/store/a5plz0p5wz8352h6cbqr497y4rn3p2rc-vlc-2.2.8/lib/vlc/plugins/stream_out/libstream_out_autodel_plugin.so
libtool: install: /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c .libs/libstream_out_autodel_plugin.lai /nix/store/a5plz0p5wz8352h6cbqr497y4rn3p2rc-vlc-2.2.8/lib/vlc/plugins/stream_out/libstream_out_autodel_plugin.la
libtool: install: warning: relinking `libstream_out_record_plugin.la'
libtool: install: (cd /build/vlc-2.2.8/modules/stream_out; /nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash /build/vlc-2.2.8/modules/stream_out/../../libtool  --silent --tag CC --mode=relink gcc -g -O2 -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -O4 -fno-math-errno -funsafe-math-optimizations -fno-rounding-math -fno-signaling-nans -fcx-limited-range -funroll-loops -fomit-frame-pointer -avoid-version -module -export-symbols-regex "^vlc_entry" -shrext .so -no-undefined ../../compat/libcompat.la ../../src/libvlccore.la -rpath /nix/store/a5plz0p5wz8352h6cbqr497y4rn3p2rc-vlc-2.2.8/lib/vlc/plugins/stream_out -o libstream_out_record_plugin.la -rpath /nix/store/a5plz0p5wz8352h6cbqr497y4rn3p2rc-vlc-2.2.8/lib/vlc/plugins/stream_out libstream_out_record_plugin_la-record.lo )
building of '/nix/store/jj3k5j1mdrf50jswrm1i43j1ir3mxr46-vlc-2.2.8.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/3vxc9583r727z9jkvahyppyl3i663m66-cantata-2.2.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3vxc9583r727z9jkvahyppyl3i663m66-cantata-2.2.0.drv' failed

@peterhoeg
Copy link
Member

Thanks for doing this but I have a separate PR that gets rid of vlc qt4 as part of the upgrade to 3.0.1 so that will supersede this: #39037

@peterhoeg peterhoeg closed this Apr 17, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cantata

Partial log (click to expand)

shrinking /nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0/lib/cantata/cantata-tags
shrinking /nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0/lib/cantata/cantata-replaygain
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0/lib  /nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0/bin
patching script interpreter paths in /nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0
/nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0/share/cantata/scripts/cantata-remote: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/4sv2088ix8jir1ykkhsvb4bnzfyfbdnc-cantata-2.2.0

@pbogdan pbogdan deleted the cantata-vlc-qt5 branch December 3, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants