Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: drop unused onlyLibVLC argument #39021

Merged
merged 1 commit into from Apr 19, 2018
Merged

vlc: drop unused onlyLibVLC argument #39021

merged 1 commit into from Apr 19, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Apr 16, 2018

Motivation for this change

nothing within nixpkgs uses this and the package doesn't actually build if it's
supplied.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pbogdan
vlc: drop unused onlyLibVLC argument
729e3b8 
nothing within nixpkgs uses this and the package doesn't actually build if it's
supplied.
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

libtool: install: /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c .libs/libvdpau_deinterlace_plugin.soT /nix/store/s2g5fybr8bcwfqm6py9s70fp0rxdqj4c-vlc-2.2.8/lib/vlc/plugins/vdpau/libvdpau_deinterlace_plugin.so
libtool: install: /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c .libs/libvdpau_deinterlace_plugin.lai /nix/store/s2g5fybr8bcwfqm6py9s70fp0rxdqj4c-vlc-2.2.8/lib/vlc/plugins/vdpau/libvdpau_deinterlace_plugin.la
libtool: install: warning: relinking `libvdpau_adjust_plugin.la'
libtool: install: (cd /build/vlc-2.2.8/modules/hw/vdpau; /nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash /build/vlc-2.2.8/modules/hw/vdpau/../../../libtool  --silent --tag CC --mode=relink gcc -I/nix/store/wn2vdrc49kk44jhplgidljwwd8ndfi9s-libvdpau-1.1.1-dev/include -g -O2 -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -O4 -fno-math-errno -funsafe-math-optimizations -fno-rounding-math -fno-signaling-nans -fcx-limited-range -funroll-loops -fomit-frame-pointer -avoid-version -module -export-symbols-regex "^vlc_entry" -shrext .so -no-undefined ../../../compat/libcompat.la ../../../src/libvlccore.la -o libvdpau_adjust_plugin.la -rpath /nix/store/s2g5fybr8bcwfqm6py9s70fp0rxdqj4c-vlc-2.2.8/lib/vlc/plugins/vdpau libvdpau_adjust_plugin_la-adjust.lo libvdpau_adjust_plugin_la-picture.lo libvlc_vdpau.la )
libtool: install: /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c .libs/libvdpau_adjust_plugin.soT /nix/store/s2g5fybr8bcwfqm6py9s70fp0rxdqj4c-vlc-2.2.8/lib/vlc/plugins/vdpau/libvdpau_adjust_plugin.so
libtool: install: /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c .libs/libvdpau_adjust_plugin.lai /nix/store/s2g5fybr8bcwfqm6py9s70fp0rxdqj4c-vlc-2.2.8/lib/vlc/plugins/vdpau/libvdpau_adjust_plugin.la
libtool: install: warning: relinking `libvdpau_sharpen_plugin.la'
libtool: install: (cd /build/vlc-2.2.8/modules/hw/vdpau; /nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash /build/vlc-2.2.8/modules/hw/vdpau/../../../libtool  --silent --tag CC --mode=relink gcc -I/nix/store/wn2vdrc49kk44jhplgidljwwd8ndfi9s-libvdpau-1.1.1-dev/include -g -O2 -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -O4 -fno-math-errno -funsafe-math-optimizations -fno-rounding-math -fno-signaling-nans -fcx-limited-range -funroll-loops -fomit-frame-pointer -avoid-version -module -export-symbols-regex "^vlc_entry" -shrext .so -no-undefined ../../../compat/libcompat.la ../../../src/libvlccore.la -o libvdpau_sharpen_plugin.la -rpath /nix/store/s2g5fybr8bcwfqm6py9s70fp0rxdqj4c-vlc-2.2.8/lib/vlc/plugins/vdpau libvdpau_sharpen_plugin_la-sharpen.lo libvdpau_sharpen_plugin_la-picture.lo libvlc_vdpau.la )
building of '/nix/store/rfs4lcl3k2s5ik8jnszy6mg1sb2ifvr8-vlc-2.2.8.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/rfs4lcl3k2s5ik8jnszy6mg1sb2ifvr8-vlc-2.2.8.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

copying path '/nix/store/ha19wzfcfgy59kf9syhwwzwl20ilcr9d-libtiff-4.0.9-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/y63mgxn4h10n6sl9klyb8dj2lnhnbk00-libmtp-1.1.15-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/7743y0j4wr3mylvjb6xi7kdbn1abj4m3-gdk-pixbuf-2.36.7-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/krf20w5iyjb2w2nz4fdfdybyd0z6fpm8-librsvg-2.42.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/c2i3abzn6rmczvibmrjxz51nk5y8wdim-ffmpeg-2.8.13-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/x9zdr6p1fwwbfir7kw8511y24aa7z3yx-samba-4.7.6-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/82w3xai5fyac5zr5zcs5yqzhfms6c2ql-ffmpeg-2.8.13-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/k5dapwxi4qvlaib8f6n9k849qx64qm8c-qt-4.8.7-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/3dbywal8x2ha03qvsrl6bps6k8vfssk0-vlc-2.2.8' from 'https://cache.nixos.org'...
/nix/store/3dbywal8x2ha03qvsrl6bps6k8vfssk0-vlc-2.2.8

@matthewbauer matthewbauer merged commit c9a3d91 into NixOS:master Apr 19, 2018
@pbogdan pbogdan deleted the vlc-obsolete-argument branch December 3, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @GrahamcOfBorg @matthewbauer