pythonPackages.yeelight: init at 0.4.0 #39023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puffnfresh
commented
Apr 16, 2018
| @@ -146,7 +146,7 @@ | |||
| "light.tikteck" = ps: with ps; [ ]; | |||
| "light.tplink" = ps: with ps; [ ]; | |||
| "light.xiaomi_miio" = ps: with ps; [ ]; | |||
| "light.yeelight" = ps: with ps; [ ]; | |||
| "light.yeelight" = ps: with ps; [ yeelight ]; | |||
There was a problem hiding this comment.
Regenerated after adding "yeelight" to Python packages
puffnfresh
force-pushed
the
package/python-yeelight
branch
from
525fe8b
to
341d397
Compare
GrahamcOfBorg
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
2.status: merge conflict
labels
dotlambda
requested changes
Apr 17, 2018
| @@ -18304,6 +18304,21 @@ EOF | |||
| h11 = callPackage ../development/python-modules/h11 { }; | |||
|
|
|||
| python-docx = callPackage ../development/python-modules/python-docx { }; | |||
|
|
|||
| yeelight = buildPythonPackage rec { | |||
There was a problem hiding this comment.
Please put the expression in its own file and use callPackage.
| @@ -18304,6 +18304,21 @@ EOF | |||
| h11 = callPackage ../development/python-modules/h11 { }; | |||
|
|
|||
| python-docx = callPackage ../development/python-modules/python-docx { }; | |||
|
|
|||
| yeelight = buildPythonPackage rec { | |||
| name = "yeelight-${version}"; | |||
There was a problem hiding this comment.
Please specify pname = "yeelight" instead. name will automatically be set by buildPythonPackage.
| yeelight = buildPythonPackage rec { | ||
| name = "yeelight-${version}"; | ||
| version = "0.4.0"; | ||
| src = pkgs.fetchurl { |
| homepage = https://gitlab.com/stavros/python-yeelight; | ||
| description = "A Python library for controlling YeeLight WiFi RGB bulbs"; | ||
| license = licenses.bsd2; | ||
| }; |
There was a problem hiding this comment.
Do you want to maintain this package?
|
Nothing happening so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)