Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass: Compile with libLAS #39027

Merged
merged 3 commits into from Apr 17, 2018
Merged

grass: Compile with libLAS #39027

merged 3 commits into from Apr 17, 2018

Conversation

mpickering
Copy link
Contributor

Motivation for this change

This enables the grass commands r.in.lidar and so on for working with lidar data.

Thanks to @LnL7 for all his help with these changes.

Subsumes #29082

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mpickering mpickering mentioned this pull request Apr 16, 2018
Closed
8 tasks
@joachifm
Copy link
Contributor

@GrahamcOfBorg build grass

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: grass

Partial log (click to expand)

/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_g3d.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_temporal.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_gmath.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_neta.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_gproj.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_dgl.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_manage.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_htmldriver.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2/grass-7.2.2/lib/libgrass_gpde.7.2.2.dylib: fixing dylib
/nix/store/izd4r4x54a1cc1mx72s6fyvm18ngi0g9-grass-7.2.2

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: grass

Partial log (click to expand)

       ^~~~~
/build/hdf-4.2.13/hdf/src/hdatainfo.h:53:32: error: unknown type name 'int32'; did you mean 'int'?
   (int32 vgid, intn attrindex, int32 *offset, int32 *length);
                                ^~~~~
                                int
building of '/nix/store/i5jnsjnjf02gn92g3k89z9khb58wg2s4-hdf-4.2.13.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/bj7rrq4w4sdb2as9gc6wcnr60050ds9d-gdal-2.2.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x71ddji531i33kjlc197qr1wbsajnlzq-libLAS-1.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1bkd824q4kn48g6rlx651avsq50v6g9h-grass-7.2.2.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/1bkd824q4kn48g6rlx651avsq50v6g9h-grass-7.2.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: grass

Partial log (click to expand)

shrinking /nix/store/713351q0k44xgcgbp5paxalwmy2a3261-libLAS-1.8.1/bin/las2txt
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/713351q0k44xgcgbp5paxalwmy2a3261-libLAS-1.8.1/lib  /nix/store/713351q0k44xgcgbp5paxalwmy2a3261-libLAS-1.8.1/bin
patching script interpreter paths in /nix/store/713351q0k44xgcgbp5paxalwmy2a3261-libLAS-1.8.1
/nix/store/713351q0k44xgcgbp5paxalwmy2a3261-libLAS-1.8.1/bin/liblas-config: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/713351q0k44xgcgbp5paxalwmy2a3261-libLAS-1.8.1...
/nix/store/3y0wxpkxzs6yz73iw35d17qr1wp4p2i4-stdenv-linux/setup: line 99: install_name_tool: command not found
builder for '/nix/store/00zhy0ddyavzsjvgz8ibfab3zq6h526f-libLAS-1.8.1.drv' failed with exit code 127
cannot build derivation '/nix/store/7af8l97f0mwyg4y55bzcfhlbfvzcn7xd-grass-7.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/7af8l97f0mwyg4y55bzcfhlbfvzcn7xd-grass-7.2.2.drv' failed

LnL7
LnL7 reviewed Apr 17, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

pkgs/development/libraries/libLAS/default.nix Outdated
"-DGDAL_CONFIG=${gdal}/bin/gdal-config"
];

postFixup = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdenv.lib.optionalString stdenv.isDarwin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@LnL7
Copy link
Member

LnL7 commented Apr 17, 2018

@GrahamcOfBorg build grass

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: grass

Partial log (click to expand)

/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_segment.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_shape.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_sim.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_sqlp.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_stats.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_symb.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_temporal.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_vector.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2/grass-7.2.2/lib/libgrass_vedit.7.2.2.dylib: fixing dylib
/nix/store/c8ph767z3wv10ischfxbz80w9l3w3vql-grass-7.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: grass

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2/lib  /nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2/bin
patching script interpreter paths in /nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2
/nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2/bin/.grass72-wrapped: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
/nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2/grass-7.2.2/gui/scripts/d.wms: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
/nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2/grass-7.2.2/gui/scripts/d.rast3d: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
/nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2/grass-7.2.2/config.status: interpreter directive changed from " /bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2/grass-7.2.2/tools/mkhtml.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
checking for references to /build in /nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2...
/nix/store/gzzl14pqczimfz67s9zrgcrwv7i8fiwp-grass-7.2.2

@LnL7 LnL7 merged commit d020809 into NixOS:master Apr 17, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: grass

Partial log (click to expand)

                  ^~~~~
                  int
/build/hdf-4.2.13/hdf/src/bitvect.h:381:35: error: unknown type name 'int32'; did you mean 'int'?
 HDFLIBAPI int32 bv_find(bv_ptr b, int32 last_find, bv_bool value);
                                   ^~~~~
building of '/nix/store/i5jnsjnjf02gn92g3k89z9khb58wg2s4-hdf-4.2.13.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/mj1k7ibccn1lsqnvd6h01r6wfqvdzjqy-gdal-2.2.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wlflw1az5lzb049jlbq3x845wa8ch3d6-libLAS-1.8.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/284hrlmyi5vmw5kjsnyl28gmh7nwz55z-grass-7.2.2.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/284hrlmyi5vmw5kjsnyl28gmh7nwz55z-grass-7.2.2.drv' failed

@luzpaz luzpaz mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpickering @joachifm @GrahamcOfBorg @LnL7 @jascase901