Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agg: disable building of examples to fix build #39041

Merged
merged 1 commit into from Apr 19, 2018

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Apr 17, 2018

Motivation for this change

Previously the build was failing with due to not being able to find libexamples.la.

/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash ../libtool  --tag=CXX   --mode=link g++  -g -O2 libexamples.la  .
./src/platform/X11/libaggplatformX11.la ../src/libagg.la  -o alpha_mask2 alpha_mask2.o
libtool:   error: cannot find the library 'libexamples.la' or unhandled argument 'libexamples.la'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Previously the build was failing with due to not being able to find
libexamples.la.
@Mic92
Copy link
Member

Mic92 commented Apr 17, 2018

@GrahamcOfBorg build agg

@Mic92 Mic92 changed the title libraries/agg: disable building of examples to fix build agg: disable building of examples to fix build Apr 17, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: agg

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: agg

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libaggplatformX11.so.2.0.4
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libaggfontfreetype.so.2.0.4
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libaggplatformsdl.so.2.0.4
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libagg.so.2.0.4
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib
patching script interpreter paths in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5
checking for references to /build in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5...
/nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: agg

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libaggfontfreetype.so.2.0.4
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libaggplatformsdl.so.2.0.4
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libaggplatformX11.so.2.0.4
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libagg.so.2.0.4
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib
patching script interpreter paths in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5
checking for references to /build in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5...
/nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5

@matthewbauer matthewbauer merged commit f1eb293 into NixOS:master Apr 19, 2018
@eqyiel eqyiel deleted the fix-agg branch November 3, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants