Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: fix files with space(s) #39116

Merged
merged 1 commit into from Apr 19, 2018
Merged

vscode: fix files with space(s) #39116

merged 1 commit into from Apr 19, 2018

Conversation

lightdiscord
Copy link
Member

Motivation for this change

If a vscode extension contains a file which contains a space it will crash.
Closes #39112

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lightdiscord lightdiscord changed the title vscode: fix files with space(s) #39112 vscode: fix files with space(s) Apr 18, 2018
@FRidh
Copy link
Member

FRidh commented Apr 18, 2018

cc @jraygauthier

@jraygauthier
Copy link
Member

@lightdiscord : Well found with clean fix. Thank you.

@lightdiscord
Copy link
Member Author

Can someone merge it ?

@FRidh FRidh merged commit e6c1354 into NixOS:master Apr 19, 2018
@FRidh
Copy link
Member

FRidh commented Apr 19, 2018

Backport needed?

@lightdiscord
Copy link
Member Author

lightdiscord commented Apr 19, 2018 •
edited

It's a bug fix so I guess it could be useful

@lightdiscord lightdiscord deleted the fix-39112 branch April 19, 2018 10:49
@grahamc
Copy link
Member

grahamc commented Apr 23, 2018

Backported in 884f78a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lightdiscord @FRidh @jraygauthier @grahamc @GrahamcOfBorg