-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement graphicsmagick-imagemagick-compat #39130
Implement graphicsmagick-imagemagick-compat #39130
Conversation
Success on x86_64-darwin (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
Same motivation drove changes in #38181, FWIW. Haven't looked at this closely but at a high level I'm strongly in favor, esp with folks from Arch and Debian leading the way. |
And it seems hard to imagine it will have a worse security track record than imagemagick :P |
@dtzWill I was thinking about a similar solution to override imagemagick. I see you introduce |
Success on x86_64-linux (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
use_gm ? true }: | ||
|
||
let | ||
convert = if use_gm then graphicsmagick-imagemagick-compat else imagemagick.out; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i would prefer if this was passed as an argument in all-packages. This makes things cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
acebb7d
to
a5a60bf
Compare
Success on x86_64-linux (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
3e1cdb5
to
0d78386
Compare
Success on x86_64-linux (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: graphicsmagick-imagemagick-compat, rivet Partial log (click to expand)
|
Motivation for this change
ImageMagick build closure now depends on librsvg and rust. This is a bit bloated and rust is often not available from Hydra. GraphicsMagick claims to be faster and seems to be compatible for various purposes.
This is inspired by:
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)