SAGA, SAGA LTS release, dependencies and QGIS SAGA plugin #39125
+166
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
8.has: package (new)
|
@GrahamcOfBorg build saga saga_2_3_2 |
|
Failure on x86_64-linux (full log) Attempted: saga, saga_2_3_2 Partial log (click to expand)
|
|
I don't understand why the build is reported as failed. It looks like it completes. |
|
Check the full log, there are some errors during the process. |
|
Failure on aarch64-linux (full log) Attempted: saga, saga_2_3_2 Partial log (click to expand)
|
|
@GrahamcOfBorg build saga_2_3_2 |
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: saga_2_3_2 Partial log (click to expand)
|
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: saga_2_3_2 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: saga_2_3_2 Partial log (click to expand)
|
There are some unresolved dependency issues which means a lot of additional dependencies have to be added explicitly on darwin but not on linux. Maybe something to do with libtool. See https://groups.google.com/forum/#!topic/nix-devel/h_vSzEJAPXs
This is the lts branch of SAGA which is currently used by QGIS 2.18.x series.
mpickering
force-pushed
the
darwin-saga
branch
from
159b503 to
115027a
Compare
|
@GrahamcOfBorg build saga_2_3_2 |
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: saga_2_3_2 Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: saga_2_3_2 Partial log (click to expand)
|
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: saga_2_3_2 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libharu, libiodbc, vigra The following builds were skipped because they don't evaluate on x86_64-darwin: saga, saga_2_3_2 Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
Everything builds here now. |
|
Failure on aarch64-linux (full log) Attempted: libharu, libiodbc, saga, saga_2_3_2, vigra Partial log (click to expand)
|
|
@GrahamcOfBorg build saga saga_2_3_2 |
|
Success on aarch64-linux (full log) Attempted: saga, saga_2_3_2 Partial log (click to expand)
|
|
I have read the code (including the referenced external patch — I noticed one). It seems to me that the code is reasonable. Aarch64 has never been built on Hydra anyway. Maybe mark as broken-if-aarch64? |
|
@GrahamcOfBorg build qgis |
|
Failure on x86_64-darwin (full log) Attempted: qgis Partial log (click to expand)
|
|
@mpickering Hydra makes me wonder if the Darwin failure of |
|
Success on x86_64-linux (full log) Attempted: saga, saga_2_3_2 Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: saga, saga_2_3_2 Partial log (click to expand)
|
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: qgis Partial log (click to expand)
|
|
Ah, OK, then it is not a regression related to this PR. Yes, it breaks nothing on Linux and looks reasonable, and it does indeed seem that you are the most .qualified person to keep track of Darwin+GIS, so let your next attempt start from a better position… @michelk what is your opinion about adding @mpickering as a co-maintainer for |
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: qgis Partial log (click to expand)
|
|
yes @7c6f434c, please add @mpickering as co-maintainer. |
7c6f434c
added a commit
to 7c6f434c/nixpkgs
that referenced
this pull request
Oct 15, 2018
|
Done |
anpryl
added a commit
to anpryl/nixpkgs
that referenced
this pull request
Oct 17, 2018
* 'master' of https://github.com/NixOS/nixpkgs: (554 commits) generators: make toPretty handle floats correctly haskell-yesod-core: disable broken test suite git-annex: update sha256 hash for the new 6.20181011 version cabal2nix: update overrides for latest yaml version hackage-packages.nix: automatic Haskell package set update hackage2nix: disable failing Hydra builds LTS Haskell 12.13 saga: add mpickering as a co-maintainer after NixOS#39125 python3Packages.cmd2: 0.9.4 -> 0.9.6 ghc: add new 8.4.4 version apvlv: add .desktop file staruml: fix download URL spectmorph: init at 0.4.1 termdown: 1.11.0 -> 1.14.1 (NixOS#48443) gotop: 1.2.9 -> 1.5.0 (NixOS#48407) emacs-mac: use generic builder dolphin-emu: fix metadata (GPLv2 -> GPLv2+, http -> https) tests/prometheus-exporters: add new Tor exporter dbeaver: 5.2.1 -> 5.2.2 nixos/hardened: add myself to maintainers ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to use SAGA plugins with QGIS. In order to do so I had to make SAGA and its dependencies build on darwin. I also had to package an older SAGA release as QGIS requires this specific version. In the end I copied the derivation rather than overriding as it was not too complicated and easier to understand this way.
Attributes to check:
saga_2_3_2andsaga.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)