Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-frameworks: 5.45 -> 5.46 #40486

Merged
merged 1 commit into from May 14, 2018
Merged

kde-frameworks: 5.45 -> 5.46 #40486

merged 1 commit into from May 14, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 14, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @bkchr @ttuegel @peterhoeg

@adisbladis adisbladis requested a review from ttuegel as a code owner May 14, 2018 09:50
bkchr
bkchr reviewed May 14, 2018
View reviewed changes
pkgs/development/libraries/kde-frameworks/ki18n.nix Outdated
@@ -14,9 +14,5 @@ mkDerivation {
propagatedNativeBuildInputs = [ gettext python ];
buildInputs = [ qtdeclarative qtscript ];
patches = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove patches completely?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels silly to have code churn around boilerplate that is likely to come back.
Anyway, I have removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay :) It's silly, but much cleaner :D

ttuegel
ttuegel approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ttuegel ttuegel merged commit 33e0763 into NixOS:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr left review comments

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @ttuegel @bkchr @GrahamcOfBorg