flent: init at 1.2.2 #40506
flent: init at 1.2.2 #40506
Conversation
|
@teto here it is |
|
One question I have is should I change the python packages inherited? |
|
|
||
| buildPythonApplication rec { | ||
| name = "flent-${version}"; | ||
| version = "1.2.2"; |
There was a problem hiding this comment.
pname="flent"
version=...
are enough, buildPythonApplication will generate the name
There was a problem hiding this comment.
ah ok, yeah I was originally doing a version from a git commit.
pkgs/top-level/all-packages.nix
Outdated
| @@ -2332,6 +2332,10 @@ with pkgs; | |||
|
|
|||
| flashrom = callPackage ../tools/misc/flashrom { }; | |||
|
|
|||
| flent = callPackage ../applications/networking/flent { | |||
There was a problem hiding this comment.
you can use python3Packages.callPackage instead and it will pass the correct parameters without you expliciting matplolib & co.
|
Whats the preferred mode of updates? squash/rebase or fixups? I like to push fixup commits so that conversations can continue without github thinking everything is handled. But I'd also like it that fixups aren't actually merged to master without first getting applied. |
|
when it's small/short commit, squashing is fine (I usually leave a 👍 in the comments to communicate I've seen/adressed them). |
|
done |
|
Looks good but I don't have merge rights. Random question but you don't intend to package from the same team (I believe) https://git.cs.kau.se/pub/kaunetem (deterministic netem) ? |
|
AFAICS the 2 projects are completely separate projects, I don't even see a common set of contributors. I do not intend to package kaunetem, it seems to have stalled though still marked as missing many features, and I have never used it so can't say if its working or not.. |
Motivation for this change
Add new package, flent for network testing.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)