Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: stumpwm: switch from package marked as broken to working quick… #40501

Merged
merged 1 commit into from May 14, 2018
Merged

nixos: stumpwm: switch from package marked as broken to working quick… #40501

merged 1 commit into from May 14, 2018

Conversation

arcadio
Copy link
Contributor

@arcadio arcadio commented May 14, 2018 •
edited

nixos: stumpwm: switch from package marked as broken to working quicklisp package

Motivation for this change

services.xserver.windowManager.stumpwm.enable is currently not working as it uses a stumpwm package explicitly marked as broken (pkgs.stumpwm). This pull request simply switches to an alternative stumpwm package (pkgs.lispPackages.stumpwm) already in NixPkgs, and which is not broken. Furthermore, this package has been built using quicklisp and, arguably, should be the preferred option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 14, 2018

currently not working as it uses a stumpwm package explicitly marked as broken (pkgs.stumpwm).

Thanks for noticing we have another package that works!

Let's get rid of the broken package (it has been broken for a while), there's no reason to keep it in addition to a working one.
Can you please add a commit to remove the broken pkgs.stumpwm so we can clean this up?

@arcadio
Copy link
Contributor Author

arcadio commented May 14, 2018 •
edited

Thanks @xeji. Could we simply go ahead with this commit without deleting the other broken package?

I'm a bit uncomfortable deleting pkgs.stumpwm, as there might be a reason to have a non-quicklisp builds we don't understand yet. I haven't explored the non-quicklisp builds NixPkgs has. Furthermore, pkgs.stumpwm is marked as broken, so it's not causing much trouble.

I can open another request to cleanup broken NixPkgs more systematically later on, once I understand the compromises involved.

@xeji
Copy link
Contributor

xeji commented May 14, 2018

Fine, let's do that and clean up later. I'm not a Lisp expert and cannot really comment on quicklisp vs. non-quicklisp. But in general, any package that has been marked broken for some time should be removed eventually - even more so when there's a working alternative.

@xeji xeji merged commit efde5fe into NixOS:master May 14, 2018
@arcadio arcadio deleted the stumpwm branch May 14, 2018 19:19
rycee pushed a commit that referenced this pull request Aug 30, 2018
@arcadio @rycee
nixos: stumpwm: switch from package marked as broken to working quick…
a37638d 
…lisp package (#40501)

(cherry picked from commit efde5fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcadio @xeji @GrahamcOfBorg