Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Init mathjax, threejs #39405

Merged
merged 2 commits into from May 6, 2018
Merged

Node: Init mathjax, threejs #39405

merged 2 commits into from May 6, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 24, 2018 •
edited

Motivation for this change

I need threejs and mathjax for sagemath. Pinging @svanderburg as I'm unsure how exactly node2nix is supposed to be used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau changed the title tNode three mathjax Node: Init mathjax, threejs Apr 24, 2018
@timokau
Copy link
Member Author

timokau commented Apr 24, 2018

nox-review fails evaluation of base16-builder in node-packages-generated.nix.

@timokau timokau changed the title Node: Init mathjax, threejs [WIP] Node: Init mathjax, threejs Apr 24, 2018
@timokau
Copy link
Member Author

timokau commented May 3, 2018

Since @svanderburg appears to be unavailable and according to the log you have some experience, could you have a look at this @Ma27?

@timokau timokau mentioned this pull request May 4, 2018
Merged
8 tasks
@Ma27
Copy link
Member

Ma27 commented May 5, 2018

First of all sorry for the slight delay 🙈

The change doens't look entirely correct to me as it seems as there's been a downgrade from 1.5.3 to 1.5.1.

In pkgs/development/node-packages you simply have to invoke ./generate.sh in order to regenerate the package set with the changes you've added.

Regarding base16-builder: I'm not entirely sure why this breaks for you as the current Hydra builds seem fine (https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.base16-builder.x86_64-linux), however let's regenerate the package set with generate.sh and see if this somehow fixes your issue :-)

@timokau
Copy link
Member Author

timokau commented May 5, 2018

Thanks for taking a look at this :)

I did generate this pr with ./generate.sh. Probably the version in the stable channel is outdated. I re-generated it with node2nix build from master.

Now nox-review fails building facette with the error "network getaddrinfo ENOTFOUND registry.npmjs.org registry.npmjs.org:443".

Thats probably because node2nix apparently always updates everything.

@Ma27
Copy link
Member

Ma27 commented May 6, 2018

yeah, seen it, however facette seems to be broken on master: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.facette.x86_64-linux/all

@timokau
Copy link
Member Author

timokau commented May 6, 2018

@GrahamcOfBorg build nodePackages_8_x.mathjax nodePackages_8_x.three

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages_8_x.mathjax, nodePackages_8_x.three

Partial log (click to expand)

patching script interpreter paths in /nix/store/dqlhldf3235409avk8c7q0v8wgxzg15b-node-three-0.92.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/dqlhldf3235409avk8c7q0v8wgxzg15b-node-three-0.92.0...
up to date in 0.17s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q6zf3w8hy2p56yh33z2njng10vwd9wb8-node-mathjax-2.7.4
patching script interpreter paths in /nix/store/q6zf3w8hy2p56yh33z2njng10vwd9wb8-node-mathjax-2.7.4
checking for references to /build in /nix/store/q6zf3w8hy2p56yh33z2njng10vwd9wb8-node-mathjax-2.7.4...
/nix/store/q6zf3w8hy2p56yh33z2njng10vwd9wb8-node-mathjax-2.7.4
/nix/store/dqlhldf3235409avk8c7q0v8wgxzg15b-node-three-0.92.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages_8_x.mathjax, nodePackages_8_x.three

Partial log (click to expand)

patching script interpreter paths in /nix/store/dgi99s48xnm6c3gfyb2wlz3qaqd8by60-node-three-0.92.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/dgi99s48xnm6c3gfyb2wlz3qaqd8by60-node-three-0.92.0...
up to date in 0.218s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lxpizknqxwlldppf6p8jxwa2nqqq73gv-node-mathjax-2.7.4
patching script interpreter paths in /nix/store/lxpizknqxwlldppf6p8jxwa2nqqq73gv-node-mathjax-2.7.4
checking for references to /build in /nix/store/lxpizknqxwlldppf6p8jxwa2nqqq73gv-node-mathjax-2.7.4...
/nix/store/lxpizknqxwlldppf6p8jxwa2nqqq73gv-node-mathjax-2.7.4
/nix/store/dgi99s48xnm6c3gfyb2wlz3qaqd8by60-node-three-0.92.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodePackages_8_x.mathjax, nodePackages_8_x.three

Partial log (click to expand)

No package-lock.json file found, reconstructing...
up to date in 0.082s
post-installation fixup
patching script interpreter paths in /nix/store/vw25y9h43ykkaijay58w5dmyii70vhry-node-three-0.92.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
up to date in 0.07s
post-installation fixup
patching script interpreter paths in /nix/store/bygchw6naki4g88d5aj8q7sr8h6dpw1p-node-mathjax-2.7.4
/nix/store/bygchw6naki4g88d5aj8q7sr8h6dpw1p-node-mathjax-2.7.4
/nix/store/vw25y9h43ykkaijay58w5dmyii70vhry-node-three-0.92.0

@Ma27
Copy link
Member

Ma27 commented May 6, 2018

@svanderburg can't we just merge this? According to Hydra facette is broken on master as well and the change seems fine IMO %)

@timokau
Copy link
Member Author

timokau commented May 6, 2018

@svanderburg hasn't answered in 12 days, so I don't think we should wait for his approval right? Especially because these auto-generated files bitrot so fast.

@Ma27
Copy link
Member

Ma27 commented May 6, 2018

I see, however I don't have commit access, so we'll need a maintainer to merge this :-)

@svanderburg svanderburg merged commit 67ef59f into NixOS:master May 6, 2018
@timokau timokau deleted the node-three-mathjax branch May 6, 2018 12:59
@timokau
Copy link
Member Author

timokau commented May 6, 2018

Oh, somehow I assumed you did.

@svanderburg Thanks!

@timokau timokau changed the title [WIP] Node: Init mathjax, threejs Node: Init mathjax, threejs May 6, 2018
@Lord-Valen Lord-Valen mentioned this pull request Aug 31, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @Ma27 @GrahamcOfBorg @svanderburg