Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine: add vulkanSupport option #39404

Merged
merged 1 commit into from May 7, 2018
Merged

wine: add vulkanSupport option #39404

merged 1 commit into from May 7, 2018

Conversation

marcinfalkiewicz
Copy link
Contributor

@marcinfalkiewicz marcinfalkiewicz commented Apr 24, 2018 •
edited

Motivation for this change

Support Vulkan API within Wine, which was merged in Wine 3.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

You probably want to add vulkanSupport = true; to full and maybe even base wine packages in pkgs/top-level/all-packages.nix.

@marcinfalkiewicz
Copy link
Contributor Author

Good point.

@Mic92
Copy link
Member

Mic92 commented Apr 24, 2018

Is there some binary I could test with this build?

@marcinfalkiewicz
Copy link
Contributor Author

marcinfalkiewicz commented Apr 25, 2018 •
edited

I've used LunarG VulkanSDK sample binaries to test it, e.g. cube.exe.

It works on Intel's Haswell IGPU as well as NVIDIA using binary blob.

@Mic92 Mic92 merged commit 2326fd2 into NixOS:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcinfalkiewicz @adisbladis @Mic92 @GrahamcOfBorg