Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple catch-all to left install.php div #2342

Merged
merged 1 commit into from May 2, 2018

Conversation

ivanovich
Copy link
Contributor

Background: I was trying to install DokuWiki in my chrooted OpenBSD webserver. The install seemed funky (generated config but not ACLs), and the installer page, instead of even showing any errors, was just blank after submitting initial parameters. Long story short, I edited install.php to approximately this effect, and finally got a visible error, which let me find out that I needed to create $CHROOT/dev/{a,u,s,}random. I would have found that out a lot sooner and torn out a lot less of my beautiful hair if something like this were already in place. After all, the installation phase is where one expects many edge cases and whatnot. Would help newcomers with strange environments to make more actionable and informative forum posts crying for help. Please consider.

Background: I was trying to install DokuWiki in my chrooted OpenBSD webserver. The install seemed funky (generated config but not ACLs), and the installer page, instead of even showing any errors, was just blank after submitting initial parameters. Long story short, I edited install.php to approximately this effect, and finally got a visible error, which let me find out that I needed to create $CHROOT/dev/{a,u,s,}random. I would have found that out a lot sooner and torn out a lot less of my beautiful hair if something like this were already in place. After all, the installation phase is where one expects many edge cases and whatnot. Would help newcomers with strange environments to make more actionable forum posts crying for help. Please consider.
@Michaelsy
Copy link
Contributor

Michaelsy commented Apr 30, 2018

👍 Particularly think of newcomers is always a good idea! Every error condition should perform as far as possible meaningful informations. Not only for newscomers.

@mprins
Copy link
Contributor

mprins commented Apr 30, 2018

OpenBSD provides a port that should take care of the chroot necessities and instructions, see https://www.dokuwiki.org/install:openbsd

@ivanovich
Copy link
Contributor Author

ivanovich commented May 2, 2018

@mprins Be that as it may, a user may want to perform a manual install for a newer version (if running OpenBSD stable), not wanting /var/www/ tied up in the package manager's records, or some other reason. Beyond that, the default OpenBSD chroot is far from the least exotic environment in which DokuWiki could find itself (ad-hoc Linux chroots, et cetera). In any event, as far as I am concerned, if something goes wrong during installation, some sort of explicit error should be provided to the user running the installer, instead of just a blank page, as pictured, and as did happen:

1525222198

Below is as it appears following the few extra lines in this PR:

1525222166

The latter let me know exactly what needed to be fixed: PHP needed a source of randomness. I then found out I could either install a few libraries like the packaged version of dokuwiki depends on, or just run MAKEDEV std in /var/www/dev after unmarking /var as nodev. I chose the latter. Again, this is far from the only possible error, and far from the only useful information the user could get.

@splitbrain splitbrain merged commit a3965d0 into dokuwiki:master May 2, 2018
@ivanovich ivanovich deleted the patch-1 branch May 2, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants