New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urn: init at 0.7.1 #40611
urn: init at 0.7.1 #40611
Conversation
}: | ||
|
||
let | ||
urnVersion = "0.7.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just call this version
|
||
stdenv.mkDerivation rec { | ||
name = "urn-${optionalString (extraLibraries != []) "with-libraries-"}${version}"; | ||
version = urnVersion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary to have version
in this attrset
src = fetchFromGitLab { | ||
owner = "urn"; | ||
repo = "urn"; | ||
rev = "381208dcaa651569d1de689384364775fa039c1c"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use rev = "v${version}"
instead? This makes it easier to update the package automatically.
@GrahamcOfBorg build urn |
Success on x86_64-darwin (full log) Attempted: urn Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: urn Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: urn Partial log (click to expand)
|
Thank you for the review! :) |
@GrahamcOfBorg build urn |
Success on x86_64-darwin (full log) Attempted: urn Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: urn Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: urn Partial log (click to expand)
|
LGTM |
Motivation for this change
Adds Urn, a powerful Lisp dialect which compiles to Lua.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)