Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urn: init at 0.7.1 #40611

Merged
merged 1 commit into from Jun 2, 2018
Merged

urn: init at 0.7.1 #40611

merged 1 commit into from Jun 2, 2018

Conversation

CrazedProgrammer
Copy link
Contributor

Motivation for this change

Adds Urn, a powerful Lisp dialect which compiles to Lua.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

}:

let
urnVersion = "0.7.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just call this version


stdenv.mkDerivation rec {
name = "urn-${optionalString (extraLibraries != []) "with-libraries-"}${version}";
version = urnVersion;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to have version in this attrset

src = fetchFromGitLab {
owner = "urn";
repo = "urn";
rev = "381208dcaa651569d1de689384364775fa039c1c";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use rev = "v${version}" instead? This makes it easier to update the package automatically.

@ryantm
Copy link
Member

ryantm commented May 26, 2018

@GrahamcOfBorg build urn

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: urn

Partial log (click to expand)

building
build flags: SHELL=/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash -B
lua bin/urn.lua urn/cli.lisp -o bin/urn.lua -O2 --plugin plugins/fold-defgeneric.lisp --plugin plugins/fold-bool.lisp --shebang --chmod
installing
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nac4mcnyx2hrshj469npmq7q7d8q23n5-urn-0.7.1/lib  /nix/store/nac4mcnyx2hrshj469npmq7q7d8q23n5-urn-0.7.1/bin
patching script interpreter paths in /nix/store/nac4mcnyx2hrshj469npmq7q7d8q23n5-urn-0.7.1
/nix/store/nac4mcnyx2hrshj469npmq7q7d8q23n5-urn-0.7.1/bin/.urn-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/j2mq8qdl7vrk3gywjn8n2ixa2lvmcwi9-urn-rt-0.7.1/bin/lua"
/nix/store/nac4mcnyx2hrshj469npmq7q7d8q23n5-urn-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: urn

Partial log (click to expand)

lua bin/urn.lua urn/cli.lisp -o bin/urn.lua -O2 --plugin plugins/fold-defgeneric.lisp --plugin plugins/fold-bool.lisp --shebang --chmod
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/na902n36l7jspxsxlib4hm16r3lvpvvh-urn-0.7.1
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/na902n36l7jspxsxlib4hm16r3lvpvvh-urn-0.7.1/lib  /nix/store/na902n36l7jspxsxlib4hm16r3lvpvvh-urn-0.7.1/bin
patching script interpreter paths in /nix/store/na902n36l7jspxsxlib4hm16r3lvpvvh-urn-0.7.1
/nix/store/na902n36l7jspxsxlib4hm16r3lvpvvh-urn-0.7.1/bin/.urn-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/yj9cskc9va1ab57rw1qdl33hm4ppggc8-urn-rt-0.7.1/bin/lua"
checking for references to /build in /nix/store/na902n36l7jspxsxlib4hm16r3lvpvvh-urn-0.7.1...
/nix/store/na902n36l7jspxsxlib4hm16r3lvpvvh-urn-0.7.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: urn

Partial log (click to expand)

lua bin/urn.lua urn/cli.lisp -o bin/urn.lua -O2 --plugin plugins/fold-defgeneric.lisp --plugin plugins/fold-bool.lisp --shebang --chmod
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f840aw3j1idacq865rp9rag1zkkfzbhc-urn-0.7.1
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f840aw3j1idacq865rp9rag1zkkfzbhc-urn-0.7.1/lib  /nix/store/f840aw3j1idacq865rp9rag1zkkfzbhc-urn-0.7.1/bin
patching script interpreter paths in /nix/store/f840aw3j1idacq865rp9rag1zkkfzbhc-urn-0.7.1
/nix/store/f840aw3j1idacq865rp9rag1zkkfzbhc-urn-0.7.1/bin/.urn-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/9z6jmbd3nrr7zlrwvm0b55q2488qh54g-urn-rt-0.7.1/bin/lua"
checking for references to /build in /nix/store/f840aw3j1idacq865rp9rag1zkkfzbhc-urn-0.7.1...
/nix/store/f840aw3j1idacq865rp9rag1zkkfzbhc-urn-0.7.1

@CrazedProgrammer
Copy link
Contributor Author

Thank you for the review! :)
Sorry for the late response, the requested changes have been made.

@ryantm
Copy link
Member

ryantm commented May 28, 2018

@GrahamcOfBorg build urn

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: urn

Partial log (click to expand)

building
build flags: SHELL=/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/bash -B
lua bin/urn.lua urn/cli.lisp -o bin/urn.lua -O2 --plugin plugins/fold-defgeneric.lisp --plugin plugins/fold-bool.lisp --shebang --chmod
installing
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2scihjw6c4lazr70lllnwczsplhff2bd-urn-0.7.1/lib  /nix/store/2scihjw6c4lazr70lllnwczsplhff2bd-urn-0.7.1/bin
patching script interpreter paths in /nix/store/2scihjw6c4lazr70lllnwczsplhff2bd-urn-0.7.1
/nix/store/2scihjw6c4lazr70lllnwczsplhff2bd-urn-0.7.1/bin/.urn-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/x0ayp4p0cxwvilcq1392v9z3j8dsy63c-urn-rt-0.7.1/bin/lua"
/nix/store/2scihjw6c4lazr70lllnwczsplhff2bd-urn-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: urn

Partial log (click to expand)

lua bin/urn.lua urn/cli.lisp -o bin/urn.lua -O2 --plugin plugins/fold-defgeneric.lisp --plugin plugins/fold-bool.lisp --shebang --chmod
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l6ncrhmbbmizrs4jxjjxrazqfva7wggp-urn-0.7.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l6ncrhmbbmizrs4jxjjxrazqfva7wggp-urn-0.7.1/lib  /nix/store/l6ncrhmbbmizrs4jxjjxrazqfva7wggp-urn-0.7.1/bin
patching script interpreter paths in /nix/store/l6ncrhmbbmizrs4jxjjxrazqfva7wggp-urn-0.7.1
/nix/store/l6ncrhmbbmizrs4jxjjxrazqfva7wggp-urn-0.7.1/bin/.urn-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/4wj0sgz6ihivrq8y381i16wzqrmmy6p1-urn-rt-0.7.1/bin/lua"
checking for references to /build in /nix/store/l6ncrhmbbmizrs4jxjjxrazqfva7wggp-urn-0.7.1...
/nix/store/l6ncrhmbbmizrs4jxjjxrazqfva7wggp-urn-0.7.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: urn

Partial log (click to expand)

lua bin/urn.lua urn/cli.lisp -o bin/urn.lua -O2 --plugin plugins/fold-defgeneric.lisp --plugin plugins/fold-bool.lisp --shebang --chmod
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w2bxwkrxd3ypbk5a117f5z653ay7zlj5-urn-0.7.1
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w2bxwkrxd3ypbk5a117f5z653ay7zlj5-urn-0.7.1/lib  /nix/store/w2bxwkrxd3ypbk5a117f5z653ay7zlj5-urn-0.7.1/bin
patching script interpreter paths in /nix/store/w2bxwkrxd3ypbk5a117f5z653ay7zlj5-urn-0.7.1
/nix/store/w2bxwkrxd3ypbk5a117f5z653ay7zlj5-urn-0.7.1/bin/.urn-wrapped: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/h32w6mp1fpff6ayxa3x9hk3pz3p0rlbw-urn-rt-0.7.1/bin/lua"
checking for references to /build in /nix/store/w2bxwkrxd3ypbk5a117f5z653ay7zlj5-urn-0.7.1...
/nix/store/w2bxwkrxd3ypbk5a117f5z653ay7zlj5-urn-0.7.1

@ryantm
Copy link
Member

ryantm commented May 28, 2018

LGTM

@matthewbauer matthewbauer merged commit e3647d7 into NixOS:master Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants