Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpack: fix up broken paths #40591

Merged
merged 1 commit into from May 16, 2018
Merged

mpack: fix up broken paths #40591

merged 1 commit into from May 16, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

mpack was trying to write to /usr/tmp which ended badly on nixos.

Fixes #40483

@clefru, do you mind giving this a go?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mpack

Partial log (click to expand)

post-installation fixup
moving /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/man to /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6
shrinking /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/bin/mpack
shrinking /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/bin/munpack
gzipping man pages under /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6/bin
patching script interpreter paths in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6
checking for references to /build in /nix/store/djaq753329njmxrdb27c0lp8g4bm9xi8-mpack-1.6...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpack

Partial log (click to expand)

moving /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/man to /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6
shrinking /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/bin/munpack
shrinking /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/bin/mpack
gzipping man pages under /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6/bin
patching script interpreter paths in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6
checking for references to /build in /nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6...
/nix/store/266q7kpnsa7whalf4hlrlxdk5lhs1cjx-mpack-1.6

@clefru
Copy link
Contributor

clefru commented May 16, 2018

@peterhoeg: Thank you for your fix! This works for me:

openat(AT_FDCWD, "/tmp/mpackxerput", O_RDWR|O_CREAT|O_EXCL, 0644) = 4

@peterhoeg peterhoeg merged commit b04e939 into NixOS:master May 16, 2018
@peterhoeg peterhoeg deleted the f/mpack branch May 16, 2018 14:46
@peterhoeg peterhoeg restored the f/mpack branch May 16, 2018 15:38
@peterhoeg peterhoeg deleted the f/mpack branch October 8, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @clefru