Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__method__ does not return valid symbol when Non-ASCII method #914

Closed
headius opened this issue Jul 25, 2013 · 3 comments
Closed

__method__ does not return valid symbol when Non-ASCII method #914

headius opened this issue Jul 25, 2013 · 3 comments
Labels
core encoding internal
Milestone
JRuby 9.2.0.0

Comments

@headius
Copy link
Member

headius commented Jul 25, 2013

Originally reported as http://jira.codehaus.org/browse/JRUBY-6055.

Kernel#method does not return valid symbol when Non-ASCII method call.

Reproduction: https://gist.github.com/headius/6076504
@DavidEGrayson DavidEGrayson mentioned this issue Dec 12, 2013
Closed
@enebo
Copy link
Member

enebo commented Feb 17, 2017

Extracting out of the gist:

# -*- mode: ruby; coding: utf-8 -*-

def こんにちは
  unless __method__ == :'こんにちは'
    raise "%s is not equals to %s" % [__method__, :'こんにちは']
  end
end

こんにちは

We have several other issues related to us not properly storing the encoding of mbc symbol names (and method table is String values).

@headius
Copy link
Member Author

headius commented Apr 27, 2017

Very likely to be fixed by identifier work @enebo is doing.

@headius headius added this to the JRuby 9.2.0.0 milestone Apr 27, 2017
@enebo enebo mentioned this issue Feb 27, 2018
Closed
@headius
Copy link
Member Author

headius commented May 16, 2018

Fixed by @enebo's symbol/identifier work.

@headius headius closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core encoding internal
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

No branches or pull requests
2 participants
@headius @enebo