Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhcp: fix compilation on gcc8 #40605

Merged
merged 1 commit into from May 16, 2018
Merged

dhcp: fix compilation on gcc8 #40605

merged 1 commit into from May 16, 2018

Conversation

Synthetica9
Copy link
Member

Motivation for this change

Not compiling under gcc8: https://hydra.nixos.org/build/74376049

Things done

Added flag -Wno-error=format-truncation

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented May 16, 2018

Did you check if upstream has an open issue for this? IMO just silencing those issues everywhere isn't a solution that scales..

@Synthetica9
Copy link
Member Author

Synthetica9 commented May 16, 2018 •
edited

I checked, it doesn't seem to be there (https://bugs.isc.org/Public/Dist/Display.html?Status=Active;Name=dhcp-public). I'll file an issue; add a link to said issue as a comment when it appears in the tracker

@Synthetica9
Copy link
Member Author

I filed an issue upstream, I'll report when I hear back.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dhcp

Partial log (click to expand)

shrinking /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/sbin/dhclient
shrinking /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/sbin/dhcrelay
gzipping man pages under /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/share/man/
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/lib  /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/bin  /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/sbin
patching script interpreter paths in /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1
/nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/sbin/.dhclient-script-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/sq6jb5limj5dsxbglam036fnvlfmn81f-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1...
moving /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/sbin/* to /nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1/bin
/nix/store/ilb90xscijgnvlgnvjnj1mb46srh78mm-dhcp-4.3.6-P1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dhcp

Partial log (click to expand)

shrinking /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/sbin/dhclient
shrinking /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/bin/omshell
gzipping man pages under /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/share/man/
strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/lib  /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/bin  /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/sbin
patching script interpreter paths in /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1
/nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/sbin/.dhclient-script-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/xdzakdwslnr0skxr9y6lr475c8sra4h1-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1...
moving /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/sbin/* to /nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1/bin
/nix/store/s4vd9nmaqma226a0rqckivs3nslp169h-dhcp-4.3.6-P1

@xeji xeji merged commit 5c225ca into NixOS:gcc8 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @andir @GrahamcOfBorg @xeji