Fix/tryton update #40606

udono · 2018-05-16T18:34:32Z

Motivation for this change

Update Tryton client (tryton) and server (trytond) package to new upstream release 4.8 last maintained by @johbo .
Add all extra dependencies.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
used instead nox-review pr 40606
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda

Please prefix the messages of the appropriate two commits with pythonPackages.

dotlambda · 2018-05-17T06:43:30Z

pkgs/development/python-modules/goocalendar/default.nix

@@ -0,0 +1,29 @@
+{ stdenv, python2Packages, pkgconfig, gobjectIntrospection, gtk3, goocanvas2 }:


For python packages, please don't pass pythonPackages as argument, but fetchPypi, pygtk, ...

If this is Python 2 only, you need to add disabled = isPy3k.

dotlambda · 2018-05-17T06:43:50Z

pkgs/development/python-modules/cdecimal/default.nix

@@ -0,0 +1,21 @@
+{ stdenv, fetchurl, python2Packages, pkgconfig }:


no python2Packages here as well.

dotlambda · 2018-05-17T06:44:11Z

pkgs/development/python-modules/cdecimal/default.nix

+  version = "2.3";
+
+  src = fetchurl {
+    url="http://www.bytereef.org/software/mpdecimal/releases/${pname}-${version}.tar.gz";


Is this not available from PyPI?

dotlambda · 2018-05-17T06:44:42Z

pkgs/development/python-modules/goocalendar/default.nix

+    description = "A calendar widget for GTK using PyGoocanvas.";
+    homepage    = https://goocalendar.tryton.org/;
+    license     = licenses.gpl2;
+    platforms   = platforms.all;


Drop this line, platforms is set automatically.

dotlambda · 2018-05-17T06:44:55Z

pkgs/development/python-modules/cdecimal/default.nix

+    description = "A fast drop-in replacement for decimal.py.";
+    homepage    = http://www.bytereef.org/mpdecimal/;
+    license     = licenses.bsd2;
+    platforms   = platforms.all;


Drop this line.

dotlambda · 2018-05-17T06:46:39Z

@GrahamcOfBorg build python2.pkgs.goocalendar python2.pkgs.cdecimal

GrahamcOfBorg · 2018-05-17T06:47:21Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.goocalendar, python2.pkgs.cdecimal

Partial log (click to expand)

gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DCONFIG_64=1 -DASM=1 -UNDEBUG -I/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/include/python2.7 -c cdecimal2.c -o build/temp.linux-x86_64-2.7/cdecimal2.o
gcc -pthread -shared -lgcc_s build/temp.linux-x86_64-2.7/basearith.o build/temp.linux-x86_64-2.7/constants.o build/temp.linux-x86_64-2.7/context.o build/temp.linux-x86_64-2.7/convolute.o build/temp.linux-x86_64-2.7/crt.o build/temp.linux-x86_64-2.7/difradix2.o build/temp.linux-x86_64-2.7/fnt.o build/temp.linux-x86_64-2.7/fourstep.o build/temp.linux-x86_64-2.7/io.o build/temp.linux-x86_64-2.7/memory.o build/temp.linux-x86_64-2.7/mpdecimal.o build/temp.linux-x86_64-2.7/numbertheory.o build/temp.linux-x86_64-2.7/sixstep.o build/temp.linux-x86_64-2.7/transpose.o build/temp.linux-x86_64-2.7/cdecimal2.o -L/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/lib -lpython2.7 -o build/lib.linux-x86_64-2.7/cdecimal.so
copying build/lib.linux-x86_64-2.7/cdecimal.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/b04bnya3g59cm8dkhzzq5dzk4yy2m28h-python2.7-GooCalendar-0.3
/nix/store/hbjxvvb1iq32wrsrgp79530cknr24741-python2.7-cdecimal-2.3

dotlambda · 2018-05-17T06:49:18Z

Ran 0 tests in 0.000s

You need to specify an appropriate checkPhase. If there are no tests, please set doCheck = false and add a comment on why they are disabled.

dotlambda · 2018-05-17T06:49:38Z

Please create a seperate commit adding yourself as a maintainer.

GrahamcOfBorg · 2018-05-17T09:40:21Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.goocalendar, python2.pkgs.cdecimal

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'GooCalendar.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/kkgh5y129v6jmbjfpb1i21r5f7mvxddc-python2.7-GooCalendar-0.3
/nix/store/qavqwqknbhln5lpdfsqqfz7abp2g0hyn-python2.7-cdecimal-2.3

Major upstream release. Use GTK-3. Use extras-depends: cdecimal, goocalendar

Major upstream release. Use extras-depends: cdecimal html2text ipaddress

udono · 2018-05-18T17:41:25Z

@dotlambda: Thank you for reviewing! I think I changed everything you requested.

dotlambda · 2018-05-18T17:45:14Z

cc @johbo

udono requested a review from FRidh as a code owner May 16, 2018 18:34

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 16, 2018

dotlambda requested changes May 17, 2018

View reviewed changes

udono force-pushed the fix/tryton-update branch from 30b1ae7 to e07a550 Compare May 18, 2018 15:54

udono added 5 commits May 18, 2018 17:17

udono: Add myself to maintainer list

0f8749b

pythonPackages goocalendar: init at 0.3

31ebb53

pythonPackages cdecimal: init at 2.3

5a3ccf1

tryton: 4.6 -> 4.8

2a1c4bf

Major upstream release. Use GTK-3. Use extras-depends: cdecimal, goocalendar

trytond: 4.6 -> 4.8

e708c8f

Major upstream release. Use extras-depends: cdecimal html2text ipaddress

udono force-pushed the fix/tryton-update branch from e07a550 to e708c8f Compare May 18, 2018 17:18

dotlambda approved these changes May 18, 2018

View reviewed changes

matthewbauer merged commit 93a5152 into NixOS:master May 19, 2018

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/tryton update #40606

Fix/tryton update #40606

udono commented May 16, 2018 •

edited

dotlambda left a comment

dotlambda May 17, 2018

dotlambda May 17, 2018

dotlambda May 17, 2018

dotlambda May 17, 2018

dotlambda May 17, 2018

dotlambda commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

dotlambda commented May 17, 2018

dotlambda commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

udono commented May 18, 2018

dotlambda commented May 18, 2018

		@@ -0,0 +1,29 @@
		{ stdenv, python2Packages, pkgconfig, gobjectIntrospection, gtk3, goocanvas2 }:

		@@ -0,0 +1,21 @@
		{ stdenv, fetchurl, python2Packages, pkgconfig }:

Fix/tryton update #40606

Fix/tryton update #40606

Conversation

udono commented May 16, 2018 • edited

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

dotlambda May 17, 2018

Choose a reason for hiding this comment

dotlambda May 17, 2018

Choose a reason for hiding this comment

dotlambda May 17, 2018

Choose a reason for hiding this comment

dotlambda May 17, 2018

Choose a reason for hiding this comment

dotlambda May 17, 2018

Choose a reason for hiding this comment

dotlambda commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

dotlambda commented May 17, 2018

dotlambda commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

udono commented May 18, 2018

dotlambda commented May 18, 2018

udono commented May 16, 2018 •

edited