Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: fix build on aarch64 with version >= 60 #40609

Merged
merged 1 commit into from May 16, 2018
Merged

firefox: fix build on aarch64 with version >= 60 #40609

merged 1 commit into from May 16, 2018

Conversation

andir
Copy link
Member

@andir andir commented May 16, 2018

Motivation for this change

The firefox build fails with an error referring to ssse2 which doesn't
exist on aarch64.

Additionally the skia code needs some patching since it tries to access functions which aren't declared on aarch64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
firefox: fix build on aarch64 with version >= 60
11af138 
The firefox build fails with an error referring to ssse2 which doesn't
exist on aarch64.
@andir andir merged commit 6b438a5 into NixOS:staging-18.03 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg