Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mattermost: 4.8.0 -> 4.10.0 #40603

Merged
merged 1 commit into from May 18, 2018
Merged

mattermost: 4.8.0 -> 4.10.0 #40603

merged 1 commit into from May 18, 2018

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented May 16, 2018 •
edited

Motivation for this change
  1. new version
  2. We were compiling the server and then overwriting it with a binary from the binary distribution. See mattermost: 4.8.0 -> 4.9.1 #39876 for details.

In the future, we should figure out how to build the webapp instead of using the binary distribution. I attempted this and opened this issue regarding building the webapp:

mattermost/mattermost#8806

cc @Mic92 for review

Things done
  • rewrote derivation as two separate derivations combined with buildEnv
  • tested NixOS service
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm ryantm changed the title matermost: 4.8.0 -> 4.10.0 mattermost: 4.8.0 -> 4.10.0 May 16, 2018
@ryantm
Copy link
Member Author

ryantm commented May 16, 2018

@GrahamcOfBorg build mattermost

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mattermost

Partial log (click to expand)

/nix/store/0m3gp218hpvsgz9ynjs5gyb7iqrikmgs-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/pelletier/go-toml/test.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/0m3gp218hpvsgz9ynjs5gyb7iqrikmgs-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/pelletier/go-toml/fuzz.sh: interpreter directive changed from " /bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/0m3gp218hpvsgz9ynjs5gyb7iqrikmgs-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/lib/pq/.travis.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/0m3gp218hpvsgz9ynjs5gyb7iqrikmgs-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/mattermost/gorp/test_all.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash -e"
/nix/store/0m3gp218hpvsgz9ynjs5gyb7iqrikmgs-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/0m3gp218hpvsgz9ynjs5gyb7iqrikmgs-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/0m3gp218hpvsgz9ynjs5gyb7iqrikmgs-mattermost-server-4.10.0...
building '/nix/store/qgaicyy244fm9np0dqa9azd8x21i2h30-mattermost-4.10.0.drv'...
created 6 symlinks in user environment
/nix/store/mhz9rlmiarn0hs9r6q2kcpi11afn1ggb-mattermost-4.10.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mattermost

Partial log (click to expand)

/nix/store/ngim47255l9kd18fx20gwhls9xs1fgx8-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/pelletier/go-toml/test.sh: interpreter directive changed from "/bin/bash" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/bash"
/nix/store/ngim47255l9kd18fx20gwhls9xs1fgx8-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/prometheus/procfs/ttar: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/bash"
/nix/store/ngim47255l9kd18fx20gwhls9xs1fgx8-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/go.uber.org/zap/check_license.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/bash -e"
/nix/store/ngim47255l9kd18fx20gwhls9xs1fgx8-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/bash"
/nix/store/ngim47255l9kd18fx20gwhls9xs1fgx8-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/bash"
/nix/store/ngim47255l9kd18fx20gwhls9xs1fgx8-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/gopkg.in/olivere/elastic.v5/run-es.sh: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/ngim47255l9kd18fx20gwhls9xs1fgx8-mattermost-server-4.10.0...
building '/nix/store/xnnqd5np0skqgnybyvvnjhkp163bxsin-mattermost-4.10.0.drv'...
created 6 symlinks in user environment
/nix/store/jn0g342jzvbv171kk6q0mh3qi5dkc2qj-mattermost-4.10.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mattermost

Partial log (click to expand)

these derivations will be built:
  /nix/store/jai96adfxd26ziwmiljmnmiia5rrg084-mattermost-server-4.10.0.drv
  /nix/store/xnnqd5np0skqgnybyvvnjhkp163bxsin-mattermost-4.10.0.drv
waiting for locks or build slots...
/nix/store/jn0g342jzvbv171kk6q0mh3qi5dkc2qj-mattermost-4.10.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mattermost

Partial log (click to expand)

/nix/store/mhz9rlmiarn0hs9r6q2kcpi11afn1ggb-mattermost-4.10.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mattermost

Partial log (click to expand)

/nix/store/4cyi9mg86l4733bzkiwllkivniy0s2fm-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/pelletier/go-toml/fuzz.sh: interpreter directive changed from " /bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/4cyi9mg86l4733bzkiwllkivniy0s2fm-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/pelletier/go-toml/test.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/4cyi9mg86l4733bzkiwllkivniy0s2fm-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/github.com/prometheus/procfs/ttar: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/4cyi9mg86l4733bzkiwllkivniy0s2fm-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/go.uber.org/zap/check_license.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash -e"
/nix/store/4cyi9mg86l4733bzkiwllkivniy0s2fm-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/4cyi9mg86l4733bzkiwllkivniy0s2fm-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/4cyi9mg86l4733bzkiwllkivniy0s2fm-mattermost-server-4.10.0/share/go/src/github.com/mattermost/mattermost-server/vendor/gopkg.in/olivere/elastic.v5/run-es.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
building '/nix/store/vw1i8ar1k4ar3jjyprd4by81qp3jx3zz-mattermost-4.10.0.drv'...
created 6 symlinks in user environment
/nix/store/m44grvcwkvfxizcyyzfczfxm09ym5fb8-mattermost-4.10.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mattermost

Partial log (click to expand)

/nix/store/m44grvcwkvfxizcyyzfczfxm09ym5fb8-mattermost-4.10.0

@Mic92 Mic92 merged commit b649537 into NixOS:master May 18, 2018
@ryantm ryantm deleted the mattermost_4_10 branch May 18, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryantm @GrahamcOfBorg @Mic92