Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildbot: disable tests because of TimeoutErrors #39826

Merged
merged 3 commits into from May 1, 2018
Merged

Conversation

seese
Copy link
Contributor

@seese seese commented May 1, 2018

Motivation for this change

buildbot does not build on aarch64 because of aborted tests

Closes #39819

Things done

Disabled tests by doCheck = false. Also removed patch-file skip_test_linux_distro.patch as it is not needed, when tests are disabled.

  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 1, 2018

buildbot does not build on aarch64 because of aborted tests.

Disabled tests by doCheck = false.

Then why not disable the tests just for aarch64 ?

@xeji
Copy link
Contributor

xeji commented May 1, 2018

There's also a version bump in #36964 .

@seese
Copy link
Contributor Author

seese commented May 1, 2018

changed the request to disable tests only on aarch64.

@xeji xeji merged commit 0a19162 into NixOS:master May 1, 2018
Synthetica9 pushed a commit to Synthetica9/nixpkgs that referenced this pull request May 3, 2018
)

buildbot: disable tests because of TimeoutErrors - only on aarch64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package buildbot is broken on aarch64
5 participants