Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-varnish-exporter: 1.2 -> 1.4, update module #39814

Merged
merged 2 commits into from May 1, 2018

Conversation

WilliButz
Copy link
Member

Things done
  • added varnish/bin to the exporter's PATH as varnishstat is expected to be in it
  • enabled the tests
  • added myself as maintainer
  • extended the module to expose most of the exporters options
  • intentionally did not expose the "-N" flag as I did not find any reference to it in varnishstat and because it could still be used with extraFlags
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @MostAwesomeDude

@WilliButz WilliButz changed the title promtheus-varnish-expoter: 1.2 -> 1.4, update module prometheus-varnish-expoter: 1.2 -> 1.4, update module May 1, 2018
@WilliButz WilliButz changed the title prometheus-varnish-expoter: 1.2 -> 1.4, update module prometheus-varnish-exporter: 1.2 -> 1.4, update module May 1, 2018
@globin globin merged commit cb4c283 into NixOS:master May 1, 2018
@WilliButz WilliButz deleted the update-varnish-exporter branch May 1, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants