Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytest-flake8: 1.0.0 -> 1.0.1 #39815

Merged
merged 3 commits into from May 2, 2018
Merged

pythonPackages.pytest-flake8: 1.0.0 -> 1.0.1 #39815

merged 3 commits into from May 2, 2018

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented May 1, 2018

Motivation for this change

This upgrade fixes #39206.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner May 1, 2018 14:24
@jluttine jluttine mentioned this pull request May 1, 2018
Closed
@dotlambda
Copy link
Member

dotlambda commented May 2, 2018 •
edited

There were at least two recent commits which disabled checks because they need pytest-flake8. These should be reverted.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pytest-flake8 python3.pkgs.pytest-flake8 python2.pkgs.keyring python3.pkgs.keyring vulnix

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pytest-flake8, python3.pkgs.pytest-flake8, python2.pkgs.keyring, python3.pkgs.keyring, vulnix

Partial log (click to expand)


----------- coverage: platform linux, python 3.6.5-final-0 -----------
Coverage HTML written to dir htmlcov

========================== 46 passed in 7.44 seconds ===========================
/nix/store/x66zcw3gb0n5di80p1lrh5h5vy2av5s7-python2.7-pytest-flake8-1.0.1
/nix/store/5p9dpkyj5xwnckhkyaz6g5bi2fvalqv9-python3.6-pytest-flake8-1.0.1
/nix/store/rl4i4rwvd2hxkwp2rxq95bj0gmcj5c4q-python2.7-keyring-12.0.1
/nix/store/9h7iyw9wdi1ddq7zyf2yfl1kx022r5ck-python3.6-keyring-12.0.1
/nix/store/q9jqlc5bm5c89wfd7yfi0s07zjdfxjdq-vulnix-1.6.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pytest-flake8, python3.pkgs.pytest-flake8, python2.pkgs.keyring, python3.pkgs.keyring, vulnix

Partial log (click to expand)


----------- coverage: platform linux, python 3.6.5-final-0 -----------
Coverage HTML written to dir htmlcov

========================= 46 passed in 123.34 seconds ==========================
/nix/store/k89zjy102avd1zyyhrnbwvl471k79irx-python2.7-pytest-flake8-1.0.1
/nix/store/spl64mpm6vr1av27sy48x9qhcfnfmb0x-python3.6-pytest-flake8-1.0.1
/nix/store/6lhx6lvj89axjk0s3281z2l1r4vnjqhh-python2.7-keyring-12.0.1
/nix/store/jcv38h6jwb0z93vsjqavc607pc8bnwdg-python3.6-keyring-12.0.1
/nix/store/qy2v99dv48nlrnihq8d2kffbpzn4l70m-vulnix-1.6.1

@dotlambda dotlambda merged commit 166282e into NixOS:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest-flake8: checkPhase failure
3 participants
@jluttine @dotlambda @GrahamcOfBorg