Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util-linux: 2.31.1 -> 2.32 #39830

Closed
wants to merge 1 commit into from
Closed

util-linux: 2.31.1 -> 2.32 #39830

wants to merge 1 commit into from

Conversation

pSub
Copy link
Member

@pSub pSub commented May 1, 2018

Motivation for this change

This update fixes CVE-2018-7738 and needs port to releases 18.03 and 17.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pSub pSub added 1.severity: security 8.has: package (update) 9.needs: port to stable A PR needs a backport to the stable release. labels May 1, 2018
@pSub pSub requested a review from dezgeg May 1, 2018 19:28
@dtzWill
Copy link
Member

dtzWill commented May 1, 2018

FWIW already on staging, see: #37814

I wasn't aware of the security implications--so it hasn't been ported elsewhere. Can someone handle this? (apologies for not doing so myself)

@edolstra
Copy link
Member

edolstra commented May 2, 2018

We shouldn't do major upgrades of util-linux on release branches. It would be better to cherry-pick the patch for the CVE, if available.

@xeji
Copy link
Contributor

xeji commented May 5, 2018

@vcunat has picked the patch for staging-18.03 in 7979cb5.

@xeji
Copy link
Contributor

xeji commented May 5, 2018

Do we still backport fixes to 17.09 ?

@vcunat
Copy link
Member

vcunat commented May 6, 2018

OK, picked the minimal patch to 17.09 as well: b26a820

@vcunat vcunat closed this May 6, 2018
@vcunat vcunat deleted the update-util-linux branch May 6, 2018 08:39
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pSub @dtzWill @edolstra @xeji @vcunat @GrahamcOfBorg @TredwellGit