Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst-plugins-base: add libopus #39824

Merged
merged 2 commits into from May 6, 2018
Merged

gst-plugins-base: add libopus #39824

merged 2 commits into from May 6, 2018

Conversation

nschoe
Copy link
Contributor

@nschoe nschoe commented May 1, 2018

Motivation for this change

When building the base plugins, gst-inspect-1.0 opus returned "plugin opus not found".

Things done

I just added the libopus dependencies in the nix-expression and in the buildInputs variable.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Thank you for your contribution! We have a few other large rebuilds pending so I think we'll merge this with those.

@peterhoeg peterhoeg changed the title Add libopus as dependency for the gstreamer base plugins gst-plugins-base: add libopus May 2, 2018
@peterhoeg peterhoeg changed the base branch from master to staging May 2, 2018 10:15
@peterhoeg peterhoeg changed the base branch from staging to master May 2, 2018 10:16
@peterhoeg
Copy link
Member

Please rebase onto staging.

@matthewbauer matthewbauer changed the base branch from master to staging May 6, 2018 01:59
@matthewbauer matthewbauer merged commit ea9656e into NixOS:staging May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: mass-rebuild 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nschoe @peterhoeg @matthewbauer @GrahamcOfBorg @Janik-Haag