pythonPackages.mail-parser: init at 3.3.1 #40353

PsyanticY · 2018-05-11T14:19:32Z

Motivation for this change

mail-parser is not only a wrapper for email Python Standard Library. It gives an easy way to pass from raw mail to Python object.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh · 2018-05-11T14:24:22Z

pkgs/development/python-modules/mail-parser/default.nix

+ pname = "mail-parser";
+ version = "3.3.1";
+
+   src = fetchPypi {


incorrect indentation

@FRidh Fixed (sorry for that)

FRidh · 2018-05-11T14:24:29Z

pkgs/development/python-modules/mail-parser/default.nix

+
+   propagatedBuildInputs = [ ipaddress six simplejson ];
+
+   doCheck = false;


Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.

PsyanticY · 2018-05-11T14:33:05Z

@FRidh Fixed indentation and enabled tests back.

dotlambda · 2018-05-11T15:51:55Z

pkgs/development/python-modules/mail-parser/default.nix

+  propagatedBuildInputs = [ ipaddress six simplejson ];
+
+  meta = with stdenv.lib; {
+     description = "A mail parser for python 2 and 3";


wrong indentation

dotlambda · 2018-05-11T15:52:04Z

pkgs/development/python-modules/mail-parser/default.nix

+  version = "3.3.1";
+
+  src = fetchPypi {
+     inherit pname version;


wrong indentation

dotlambda · 2018-05-11T15:52:51Z

Instead of removing meta.maintainers, you should add yourself to https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix.

PsyanticY · 2018-05-11T16:35:54Z

@dotlambda Addressed your comments ^^ .

dotlambda · 2018-05-11T16:35:57Z

@GrahamcOfBorg build python2.pkgs.mail-parser python3.pkgs.mail-parser

GrahamcOfBorg · 2018-05-11T16:36:25Z

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.mail-parser, python3.pkgs.mail-parser

Partial log (click to expand)

reading manifest file 'mail_parser.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'mail_parser.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
error: build of '/nix/store/hw75k2xvyns149wixzg2s32k4xjv95bb-python3.6-mail-parser-3.3.1.drv' failed

GrahamcOfBorg · 2018-05-11T16:36:41Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.mail-parser, python3.pkgs.mail-parser

Partial log (click to expand)

reading manifest file 'mail_parser.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'mail_parser.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
�[31;1merror:�[0m build of '/nix/store/2mg5y87yr3js3p8lza05y097pqlxsrj5-python3.6-mail-parser-3.3.1.drv' failed

dotlambda · 2018-05-11T16:39:05Z

Ran 0 tests in 0.000s

You have to specify an appropriate checkPhase.

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 6050: ordinal not in range(128)

This probably means you have to set LC_ALL and add glibcLocales to nativeBuildInputs.

PsyanticY · 2018-05-12T21:01:12Z

@dotlambda Fixed the decoding issue. When building the package on python 3.6 it complaion about the unavailability of the package "ipaddress". it turns out that the package is enabled for python 3.2 or less.
ipaddress = if (pythonAtLeast "3.3") then null else buildPythonPackage rec{
I removed that and build if for python36 and 35 successfully. I think the (pythonAtLeast "3.3") was due to this description of the package "Python 3.3+'s ipaddress for Python 2.6, 2.7, 3.2." i created an issue and asked the package owner why is that the case. he affirmed the following: ""By the way, 3.3+ means 3.3 or any newer version, e.g. 3.4, 3.5, 3.6, 4.0.""", here is the issue

FRidh

When building the package on python 3.6 it complaion about the unavailability of the package "ipaddress". it turns out that the package is enabled for python 3.2 or less.

That's because new versions of Python have it as part of stdlib.

I removed that and build if for python36 and 35 successfully.

No, that should not be done, because we should avoid shadowing standard library modules. The package mail-parser should only depend on ipaddress for older versions of Python.

FRidh · 2018-05-13T08:23:04Z

pkgs/development/python-modules/mail-parser/default.nix

@@ -0,0 +1,26 @@
+{ stdenv, pkgs, buildPythonPackage, glibcLocales, fetchPypi, ipaddress, six, simplejson }:


FRidh · 2018-05-13T08:27:25Z

pkgs/top-level/python-packages.nix

@@ -6699,7 +6701,7 @@ in {
    };
  };

-  ipaddress = if (pythonAtLeast "3.3") then null else buildPythonPackage rec {
+  ipaddress = buildPythonPackage rec {


this needs to be undone

PsyanticY · 2018-05-16T16:51:37Z

@dotlambda Can you please take a look ^_^

dotlambda · 2018-05-17T06:33:50Z

@Assassinkin Please have a look at my changes.

@GrahamcOfBorg build python2.pkgs.mail-parser python3.pkgs.mail-parser

GrahamcOfBorg · 2018-05-17T06:34:12Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.mail-parser, python3.pkgs.mail-parser

Partial log (click to expand)

        "StartBoundaryNotFoundDefect: The claimed start boundary was never found.",
        "MultipartInvariantViolationDefect: A message claimed to be a multipart but no subparts were found."
      ]
    }
  ],
  "defects_categories": [
    "MultipartInvariantViolationDefect",
    "StartBoundaryNotFoundDefect"
  ]
}

GrahamcOfBorg · 2018-05-17T06:39:04Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.mail-parser, python3.pkgs.mail-parser

Partial log (click to expand)

      ]
    }
  ],
  "defects_categories": [
    "MultipartInvariantViolationDefect",
    "StartBoundaryNotFoundDefect"
  ]
}
/nix/store/819dksk3cm5jndj4kdpi5cndhd1sy26j-python2.7-mail-parser-3.3.1
/nix/store/lamxjaljnsbsvfsci4384y58vjybqhkf-python3.6-mail-parser-3.3.1

PsyanticY · 2018-05-17T10:01:56Z

@dotlambda Looks way better. Thanks for the help.

PsyanticY requested a review from FRidh as a code owner May 11, 2018 14:19

GrahamcOfBorg added the 6.topic: python label May 11, 2018

FRidh requested changes May 11, 2018

View reviewed changes

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 11, 2018

dotlambda reviewed May 11, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 12, 2018

FRidh requested changes May 13, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ labels May 14, 2018

dotlambda force-pushed the mail-parser branch 3 times, most recently from 1efac83 to ce921cd Compare May 17, 2018 06:28

dotlambda changed the title ~~mail-parser python(2/3) package~~ pythonPackages.mail-parser: init at 3.3.1 May 17, 2018

add psyanticy as maintainer

dd51a4a

dotlambda force-pushed the mail-parser branch from ce921cd to ecf8d8e Compare May 17, 2018 06:31

pythonPackages.mail-parser: init at 3.3.1

fb7340d

dotlambda force-pushed the mail-parser branch from ecf8d8e to fb7340d Compare May 17, 2018 10:22

dotlambda merged commit 2c91ab5 into NixOS:master May 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.mail-parser: init at 3.3.1 #40353

pythonPackages.mail-parser: init at 3.3.1 #40353

PsyanticY commented May 11, 2018 •

edited

FRidh May 11, 2018

PsyanticY May 11, 2018

FRidh May 11, 2018

PsyanticY commented May 11, 2018

dotlambda May 11, 2018

dotlambda May 11, 2018

dotlambda commented May 11, 2018

PsyanticY commented May 11, 2018

dotlambda commented May 11, 2018

GrahamcOfBorg commented May 11, 2018

GrahamcOfBorg commented May 11, 2018

dotlambda commented May 11, 2018

PsyanticY commented May 12, 2018

FRidh left a comment

FRidh May 13, 2018

FRidh May 13, 2018

PsyanticY commented May 16, 2018

dotlambda commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

PsyanticY commented May 17, 2018


		propagatedBuildInputs = [ ipaddress six simplejson ];

		doCheck = false;

		@@ -0,0 +1,26 @@
		{ stdenv, pkgs, buildPythonPackage, glibcLocales, fetchPypi, ipaddress, six, simplejson }:

pythonPackages.mail-parser: init at 3.3.1 #40353

pythonPackages.mail-parser: init at 3.3.1 #40353

Conversation

PsyanticY commented May 11, 2018 • edited

Motivation for this change

Things done

FRidh May 11, 2018

Choose a reason for hiding this comment

PsyanticY May 11, 2018

Choose a reason for hiding this comment

FRidh May 11, 2018

Choose a reason for hiding this comment

PsyanticY commented May 11, 2018

dotlambda May 11, 2018

Choose a reason for hiding this comment

dotlambda May 11, 2018

Choose a reason for hiding this comment

dotlambda commented May 11, 2018

PsyanticY commented May 11, 2018

dotlambda commented May 11, 2018

GrahamcOfBorg commented May 11, 2018

GrahamcOfBorg commented May 11, 2018

dotlambda commented May 11, 2018

PsyanticY commented May 12, 2018

FRidh left a comment

Choose a reason for hiding this comment

FRidh May 13, 2018

Choose a reason for hiding this comment

FRidh May 13, 2018

Choose a reason for hiding this comment

PsyanticY commented May 16, 2018

dotlambda commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

PsyanticY commented May 17, 2018

PsyanticY commented May 11, 2018 •

edited