strongswan: include curl plugin by default #39506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on aarch64-linux (full log) Attempted: strongswan Partial log (click to expand)
|
|
cc @basvandijk @ryantm @erickg @dhess, does this look reasonable to you? |
|
IMHO it makes sense and it is a sensible common enough case 👍 |
|
Success on x86_64-linux (full log) Attempted: strongswan Partial log (click to expand)
|
|
According to https://wiki.strongswan.org/projects/strongswan/wiki/Curl, you either need to pass How can we detect which crypto backend curl is using? I see the curl derivation is putting Maybe we could put |
|
It looks like we're already setting |
|
Note that users can override curl's crypto backend using: curl.override { gnutlsSupport = true; sslSupport = false; };This happens in a few places in nixpkgs. I'm not sure how common this is in users configs. But it should be easy to detect using my proposed method. |
|
OK, I've added the requested changes - curl includes gnutlsSupport in its passthru data, and strongswan matches its --enable-openssl/--enable-gcrypt flags to what curl does. Look good? |
|
Success on x86_64-linux (full log) Attempted: curl, strongswan Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: curl, strongswan Partial log (click to expand)
|
|
Unfortunately the following fails: I'm trying to get the strongswan gcrypt plugin to work on the strongswan-curl-gcrypt branch but I'm failing so far: Maybe it's better for now to go with your first commit (93031e5) and fix the gcrypt situation later... |
OK. I'll add a note in strongswan/default.nix about it too. |
This is necessary for OCSP and/or remote CRL verification of server certificates to work, which is a fairly common thing to need.
|
Success on x86_64-linux (full log) Attempted: strongswan Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: strongswan Partial log (click to expand)
|
Synthetica9
pushed a commit
to Synthetica9/nixpkgs
that referenced
this pull request
May 3, 2018
This is necessary for OCSP and/or remote CRL verification of server certificates to work, which is a fairly common thing to need.
basvandijk
pushed a commit
to LumiGuide/nixpkgs
that referenced
this pull request
Jun 24, 2018
This is necessary for OCSP and/or remote CRL verification of server certificates to work, which is a fairly common thing to need. (cherry picked from commit 1022dc5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is necessary for OCSP and/or remote CRL verification of server
certificates to work, which is a fairly common thing to need.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)