Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dit: 0.4 -> 0.5 #39505

Merged
merged 3 commits into from Feb 17, 2019
Merged

dit: 0.4 -> 0.5 #39505

merged 3 commits into from Feb 17, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Apr 25, 2018 •
edited

Motivation for this change

Update to latest version.

Also preparations for darwin support, but it currently don't build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member Author

davidak commented Apr 25, 2018

Build still fails on darwin: hishamhm/dit#23

We have to wait for upstream fix.

@davidak
dit: 0.4 -> 0.5
6142e26 
adds darwin support
should work on *BSD
@nlewo
Copy link
Member

nlewo commented May 9, 2018

@GrahamcOfBorg build dit

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dit

Partial log (click to expand)

make[2]: Leaving directory '/build/dit-0.5'
make[1]: Leaving directory '/build/dit-0.5'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5
shrinking /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5/bin/dit
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5/bin
patching script interpreter paths in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5
checking for references to /build in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5...
/nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dit

Partial log (click to expand)

make[2]: Leaving directory '/build/dit-0.5'
make[1]: Leaving directory '/build/dit-0.5'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5
shrinking /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5/bin/dit
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5/bin
patching script interpreter paths in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5
checking for references to /build in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5...
/nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5

@xeji
Copy link
Contributor

xeji commented May 11, 2018

@GrahamcOfBorg build dit

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: dit

Partial log (click to expand)

checking for unistd.h... yes
checking ncursesw/curses.h usability... yes
checking ncursesw/curses.h presence... yes
checking for ncursesw/curses.h... yes
checking for iconv in -liconv... yes
checking for clock_gettime in -lc... no
checking for clock_gettime in -lrt... no
configure: error: missing libraries:  librt
builder for '/nix/store/1pb98l2w64vkdga629k9hj8nbk7x8j6l-dit-0.5.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/1pb98l2w64vkdga629k9hj8nbk7x8j6l-dit-0.5.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dit

Partial log (click to expand)

make[2]: Leaving directory '/build/dit-0.5'
make[1]: Leaving directory '/build/dit-0.5'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5
shrinking /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5/bin/dit
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5/bin
patching script interpreter paths in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5
checking for references to /build in /nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5...
/nix/store/mb7sr3p3niidr2v98waajmwskankkwlz-dit-0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dit

Partial log (click to expand)

make[2]: Leaving directory '/build/dit-0.5'
make[1]: Leaving directory '/build/dit-0.5'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5
shrinking /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5/bin/dit
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5/bin
patching script interpreter paths in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5
checking for references to /build in /nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5...
/nix/store/kdmb2nxdxdran85dc18rdbm9plidg9sj-dit-0.5

@Ekleog
Copy link
Member

Ekleog commented Oct 11, 2018

(triage) The merge conflict is just due to the removed unused lib argument.

Suggestion: revert the change trying to make this work on darwin, as this update works on linux and does bring in an update. Work for darwin port later on.

@davidak
Copy link
Member Author

davidak commented Oct 11, 2018

still waiting for upstream. i think the darwin build was the only change this new version should fix. it's not on the official website...

should i close this and open a new PR when upstream has fixed it?

@Ekleog
Copy link
Member

Ekleog commented Oct 11, 2018

Hmm… Looking quickly at the history, I think there are other changes brought forth by this new version, like “Don't consider _ a word-delimiter when using multiple cursors” or “Persistent redo”.

So I think linux users could benefit right now from the version bump, and once upstream answers, the darwin build will be possible to fix and get in nixpkgs? :)

@davidak
Copy link
Member Author

davidak commented Jan 26, 2019

@Ekleog you are right. I limited it again to linux.

The project is not very actively developed, so it makes no sense to wait any longer.

Please squash when merging.

(Take a look at micro for a similar, but active project)

@davidak davidak changed the title [WIP] dit: 0.4 -> 0.5 dit: 0.4 -> 0.5 Jan 26, 2019
@Ekleog
Copy link
Member

Ekleog commented Jan 26, 2019

@GrahamcOfBorg build dit

@ryantm ryantm merged commit 2646ce0 into NixOS:master Feb 17, 2019
@davidak davidak deleted the dit-update branch February 17, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@davidak @nlewo @GrahamcOfBorg @xeji @Ekleog @ryantm