Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: 7.2.4 -> 7.2.5 #39528

Merged
merged 1 commit into from Apr 28, 2018
Merged

php: 7.2.4 -> 7.2.5 #39528

merged 1 commit into from Apr 28, 2018

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/php/versions.

These checks were done:

  • built on NixOS
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phar.phar help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phar help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php -h’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php --help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phpdbg help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-cgi -h’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-cgi --help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear -h’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear --help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev -h’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev --help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl -h’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl --help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl help’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-fpm -h’ got 0 exit code
  • ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-fpm --help’ got 0 exit code
  • found 7.2.5 with grep in /nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5
  • directory tree listing: https://gist.github.com/c9aa24f676de9bcd4cc434c086932362

cc @globin @etu for review

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/php/versions.

These checks were done:

- built on NixOS
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phar.phar help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phar help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php -h’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php --help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phpdbg help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-cgi -h’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-cgi --help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear -h’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear --help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev -h’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev --help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl -h’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl --help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl help’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-fpm -h’ got 0 exit code
- ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-fpm --help’ got 0 exit code
- found 7.2.5 with grep in /nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5
- directory tree listing: https://gist.github.com/c9aa24f676de9bcd4cc434c086932362
@etu
Copy link
Contributor

etu commented Apr 26, 2018

@GrahamcOfBorg build php72

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php72

Partial log (click to expand)

/nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5...
moving /nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5/sbin/* to /nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/s3x6ky7k00ag4yp0f6y6xy4j015a170q-php-7.2.5-dev
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/s3x6ky7k00ag4yp0f6y6xy4j015a170q-php-7.2.5-dev
checking for references to /build in /nix/store/s3x6ky7k00ag4yp0f6y6xy4j015a170q-php-7.2.5-dev...
/nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/h1kgkbxz92s9j1laxhph8a63pxxfjvq1-php-7.2.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: php

Partial log (click to expand)

/nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/bin/pecl: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
moving /nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/sbin/* to /nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5/bin
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/pwhfa31rkii8nblfr8a1rbi3qpzgxndh-php-7.2.5-dev
/nix/store/ibgxb16jzbhj64ma1kwdy1kcfps1wzs8-php-7.2.5

@etu
Copy link
Contributor

etu commented Apr 26, 2018

I've managed to build all the things except hhvm when doing a nox-review on this PR.

@GrahamcOfBorg build hhvm

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: hhvm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@etu
Copy link
Contributor

etu commented Apr 26, 2018

Now there's a ChangeLog for this released. It wasn't out yet when this PR was made.

https://secure.php.net/ChangeLog-7.php#7.2.5

We do need to backport this to 18.03 (not earlier releases since 7.2 wasn't in there) due to security related updates.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php72

Partial log (click to expand)

/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5...
moving /nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/sbin/* to /nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/p3knik701gkgkl3w6kh951wwqfsklwqk-php-7.2.5-dev
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/p3knik701gkgkl3w6kh951wwqfsklwqk-php-7.2.5-dev
checking for references to /build in /nix/store/p3knik701gkgkl3w6kh951wwqfsklwqk-php-7.2.5-dev...
/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php

Partial log (click to expand)

these derivations will be built:
  /nix/store/2dc1g9li2s6h41xbq5brzhfprwgyyg3v-php-7.2.5.drv
waiting for locks or build slots...
/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: hhvm

Partial log (click to expand)

[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/licm.cpp.o
[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/irlower.cpp.o
[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/irlower-surprise.cpp.o
[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/irlower-type.cpp.o
[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/irlower-string.cpp.o
[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/mutation.cpp.o
[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/native-calls.cpp.o
[ 75%] Building CXX object hphp/runtime/CMakeFiles/hphp_runtime_static.dir/vm/jit/normalized-instruction.cpp.o
building of '/nix/store/7b2cqv08r6r0l51xaiwxm2351aws6grp-hhvm-3.23.2.drv' timed out after 4000 seconds
error: build of '/nix/store/7b2cqv08r6r0l51xaiwxm2351aws6grp-hhvm-3.23.2.drv' failed

@etu
Copy link
Contributor

etu commented Apr 26, 2018

Well, hhvm seems to not build. But from my testing I can confirm that it didn't build without the PHP update anyway. So this PR doesn't change anything regarding hhvm.

Therefore I say, this PR looks good to me. But needs backporting to 18.03. I hope someone with commit access comes around to do this 👍

@Mic92 Mic92 merged commit df8d216 into NixOS:master Apr 28, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 28, 2018

18.03:

[detached HEAD a67a7e4] php: 7.2.4 -> 7.2.5
Author: R. RyanTM ryantm+bot@ryantm.com
Date: Wed Apr 25 23:57:03 2018 -0700
1 file changed, 2 insertions(+), 2 deletions(-)

@r-ryantm r-ryantm deleted the auto-update/php branch April 28, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants