New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php: 7.2.4 -> 7.2.5 #39528
php: 7.2.4 -> 7.2.5 #39528
Conversation
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/php/versions. These checks were done: - built on NixOS - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phar.phar help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phar help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php -h’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php --help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/phpdbg help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-cgi -h’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-cgi --help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear -h’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear --help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pear help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev -h’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev --help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/peardev help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl -h’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl --help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/pecl help’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-fpm -h’ got 0 exit code - ran ‘/nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5/bin/php-fpm --help’ got 0 exit code - found 7.2.5 with grep in /nix/store/zlkvhv6z2l08gawl8w2vnc7pb3v6p815-php-7.2.5 - directory tree listing: https://gist.github.com/c9aa24f676de9bcd4cc434c086932362
@GrahamcOfBorg build php72 |
Success on aarch64-linux (full log) Attempted: php72 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: php Partial log (click to expand)
|
I've managed to build all the things except hhvm when doing a @GrahamcOfBorg build hhvm |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: hhvm Partial log (click to expand)
|
Now there's a ChangeLog for this released. It wasn't out yet when this PR was made. https://secure.php.net/ChangeLog-7.php#7.2.5 We do need to backport this to 18.03 (not earlier releases since 7.2 wasn't in there) due to security related updates. |
Success on x86_64-linux (full log) Attempted: php72 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: php Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: hhvm Partial log (click to expand)
|
Well, hhvm seems to not build. But from my testing I can confirm that it didn't build without the PHP update anyway. So this PR doesn't change anything regarding hhvm. Therefore I say, this PR looks good to me. But needs backporting to 18.03. I hope someone with commit access comes around to do this 👍 |
18.03: [detached HEAD a67a7e4] php: 7.2.4 -> 7.2.5 |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/php/versions.
These checks were done:
cc @globin @etu for review