Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 52a1832eae60
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9b1e93bfc594
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Apr 25, 2018

  1. Copy the full SHA
    c72db7f View commit details
  2. Copy the full SHA
    09d2e29 View commit details
  3. Copy the full SHA
    43ecac4 View commit details
  4. Copy the full SHA
    9b1e93b View commit details
Showing with 10 additions and 6 deletions.
  1. +7 −6 core/src/main/java/org/jruby/RubyProc.java
  2. +1 −0 test/mri/excludes/TestProcess.rb
  3. +1 −0 test/mri/excludes/TestRubyOptimization.rb
  4. +1 −0 test/mri/excludes/TestRubyOptions.rb
13 changes: 7 additions & 6 deletions core/src/main/java/org/jruby/RubyProc.java
Original file line number Diff line number Diff line change
@@ -215,16 +215,12 @@ public IRubyObject dup() {
}

@Override
public IRubyObject to_s() {
return to_s19();
}

@JRubyMethod(name = "to_s", alias = "inspect")
public IRubyObject to_s19() {
public IRubyObject to_s() {
Ruby runtime = getRuntime();
RubyString string = runtime.newString("#<");

string.append(types(runtime, getMetaClass()));
string.append(types(runtime, type()));
string.catString(":0x" + Integer.toString(System.identityHashCode(block), 16));

String file = block.getBody().getFile();
@@ -349,4 +345,9 @@ public final IRubyObject call19(ThreadContext context, IRubyObject[] args, Block
return call(context, args, block);
}

@Deprecated
public IRubyObject to_s19() {
return to_s();
}

}
1 change: 1 addition & 0 deletions test/mri/excludes/TestProcess.rb
Original file line number Diff line number Diff line change
@@ -45,6 +45,7 @@
exclude :test_fd_inheritance, "unimplemented: cyclic redirects in child are not supported"
exclude :test_gid_re_exchangeable_p, "unimplemented"
exclude :test_gid_sid_available?, "unimplemented"
exclude :test_initgroups, "unimplemented"
exclude :test_kill_at_spawn_failure, "thread lifecycle at process boundaries?"
exclude :test_no_curdir, "won't work due changed wd detection (since 1e30600bdbbf483a)"
exclude :test_popen_exit, "terminates test run"
1 change: 1 addition & 0 deletions test/mri/excludes/TestRubyOptimization.rb
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@
exclude :test_string_freeze, "frozen string literal should be a new object if String#freeze is redefined (#2156)"
exclude :test_string_freeze_block, "frozen string literal revert to a call if String#freeze is redefined (#2156)"
exclude :test_string_freeze_saves_memory, "depends on ObjectSpace#memsize_of"
exclude :test_string_uminus, "frozen string literal revert to a call if String#-@ is redefined (#2156)"
exclude :test_tailcall, "needs investigation"
exclude :test_tailcall_condition_block, "depends on RubyVM"
exclude :test_tailcall_inhibited_by_block, "depends on RubyVM"
1 change: 1 addition & 0 deletions test/mri/excludes/TestRubyOptions.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
exclude :test_assignment_in_conditional, "line numbers don't match MRI"
exclude :test_chdir, "needs investigation"
exclude :test_copyright, "needs investigation"
exclude :test_cwd_encoding, "can't do chdir and env yet #5145"
exclude :test_debug, "needs investigation"
exclude :test_dump_insns_with_rflag, "MRI-specific format"
exclude :test_dump_parsetree_with_rflag, "MRI-specific format"