Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] NixOS: Add networking.rini module #39691

Closed
wants to merge 5 commits into from
Closed

[WIP] NixOS: Add networking.rini module #39691

wants to merge 5 commits into from

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Apr 29, 2018

Motivation for this change

RINA is a new and better Internetwork architecture. IRATI is an implementation of RINA for Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

peterhoeg
peterhoeg reviewed May 2, 2018
View reviewed changes
nixos/modules/services/networking/rina.nix Outdated
path = [ cfg.package ];
preStart = ''
mkdir -p /var/log/irati
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do serviceConfig.LogsDirectory = "irati"; instead of manually creating the directory.

nixos/modules/services/networking/rina.nix Outdated
description = "RINA IPC Manager Daemon";

before = [ "network.target" ];
wants = [ "network.target" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this - multi-user will bring in network.target so you just need to position yourself before it (like you do in the earlier line).

nixos/modules/services/networking/rina.nix Outdated
wantedBy = [ "multi-user.target" ];
# stopIfChanged = false;

path = [ cfg.package ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed when you reference the full path in ExecStart?

nixos/modules/services/networking/rina.nix Outdated
difConfigurations = map mkDifConfig cfg.difs;
ipcProcessesToCreate = cfg.ipcs;
localConfiguration = {
consoleSocket = "/var/run/ipcm-console.sock";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/run is deprecated. Should just be /run.

@rvl
Copy link
Contributor Author

rvl commented May 2, 2018

Thanks @peterhoeg - very helpful! I will fix those things shortly. And I also want to add a couple more test scenarios and fix the bug in existing test.

@miguelpdl
Copy link

+1

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:13
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: work-in-progress 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rvl @miguelpdl @mmahut @peterhoeg @ryantm @AndersonTorres @GrahamcOfBorg