Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tempita: 0.5.2 -> 0.5.3-2016-09-28, Python 3 support #39692

Closed
wants to merge 1 commit into from

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Tempita is abandoned upstream (no release since 2013, website redirects to archive.org), but sqlalchemy-migrate depends on it. There is a fork available that fixes Python 3 compatibility. This fork is used by the official Arch Linux tempita package.

Things done

This PR updates tempita to use this fork, so that it works with Python 3.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Have they tried to get it included in pypi? We normally want to just use releases in that.

@FRidh
Copy link
Member

FRidh commented May 9, 2018

We typically indeed only stick to releases, and preferably those that are on PyPI. Sometimes, it simply happens that packages are abandoned, and sometimes forks are created and maintained.

Preferably, the fork would:

  1. cut releases
  2. request usage of the tempita name on PyPI

Could you ask if they could? Otherwise, we could use this one anyway. In that case, point to the date of the revision, and use that as version.

@lopsided98 lopsided98 changed the title tempita: 0.5.2 -> 0.5.3dev47414a7, Python 3 support tempita: 0.5.2 -> 0.5.3-2016-09-28, Python 3 support Jun 6, 2018
@lopsided98
Copy link
Contributor Author

Superseded by #45890

@lopsided98 lopsided98 closed this Oct 12, 2018
@lopsided98 lopsided98 deleted the tempita-update branch October 12, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants