Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: add pcre2 as build dep for searching in journalctl #39698

Merged
merged 1 commit into from Apr 30, 2018
Merged

systemd: add pcre2 as build dep for searching in journalctl #39698

merged 1 commit into from Apr 30, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 30, 2018

"journalctl --grep" doesn't work, says wasn't compiled with pattern matching support.

So perhaps we should make it available?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systemd

Partial log (click to expand)

Cannot nix-instantiate `systemd' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13988:13:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:16:1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systemd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vjklgnf9zj59sf4lbrpdgra0d761g1x1-systemd-238-man
gzipping man pages under /nix/store/vjklgnf9zj59sf4lbrpdgra0d761g1x1-systemd-238-man/share/man/
strip is /nix/store/fzj1a9khx6wwp3zlf8lkf6kv17x1g5gb-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vjklgnf9zj59sf4lbrpdgra0d761g1x1-systemd-238-man
checking for references to /build in /nix/store/vjklgnf9zj59sf4lbrpdgra0d761g1x1-systemd-238-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/g98i9qxlb7p0bfyx89px51p0rihgacg9-systemd-238-dev
strip is /nix/store/fzj1a9khx6wwp3zlf8lkf6kv17x1g5gb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g98i9qxlb7p0bfyx89px51p0rihgacg9-systemd-238-dev/lib
patching script interpreter paths in /nix/store/g98i9qxlb7p0bfyx89px51p0rihgacg9-systemd-238-dev
checking for references to /build in /nix/store/g98i9qxlb7p0bfyx89px51p0rihgacg9-systemd-238-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd

Partial log (click to expand)

gzipping man pages under /nix/store/l7z8r3dwpqm218qq5f9qx1z0z2hmfxgl-systemd-238-man/share/man/
strip is /nix/store/a8dd4rd03jylyb82ndx5r9f4rjp0nprn-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/l7z8r3dwpqm218qq5f9qx1z0z2hmfxgl-systemd-238-man
checking for references to /build in /nix/store/l7z8r3dwpqm218qq5f9qx1z0z2hmfxgl-systemd-238-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/mz0570ldjx9gy6hrccp657zcjvli794l-systemd-238-dev
strip is /nix/store/a8dd4rd03jylyb82ndx5r9f4rjp0nprn-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mz0570ldjx9gy6hrccp657zcjvli794l-systemd-238-dev/lib
patching script interpreter paths in /nix/store/mz0570ldjx9gy6hrccp657zcjvli794l-systemd-238-dev
checking for references to /build in /nix/store/mz0570ldjx9gy6hrccp657zcjvli794l-systemd-238-dev...
/nix/store/ddnv9wxlq20j45jidqjyr3z6gyapn0w5-systemd-238

@dtzWill dtzWill merged commit 2d7e313 into NixOS:staging Apr 30, 2018
@dtzWill dtzWill deleted the fix/systemd-pcre2-dep branch April 30, 2018 17:19
@jtojnar jtojnar mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg