Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: get enableParallelBuilding compatible with bmake #39699

Closed
wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Apr 30, 2018

The BSD version of make requires a space after "-j". In addition BSD make does not recognize the "--load-avg" option. From what I can tell this should be okay because load average already should default to the value set by "-j". Need more research on whether this is correct.

This is more of a proof of concept. Right now we can just set these args manually with BSD make.

The BSD version of make requires a space after "-j". In addition BSD make does not recognize the "--load-avg" option. From what I can tell this should be okay because load average already should default to the value set by "-j". Need more research on whether this is correct.
@symphorien
Copy link
Member

From what I can tell this should be okay because load average already should default to the value set by "-j". Need more research on whether this is correct.

I think that -j2 -l2 and -j2 are not equivalent. For example, if you only have 2 cores, and you launch 2 such builds, with the former you get a load of 2, and with the latter you get a load of 4 (2 for each build).
So preserving -l when supported by make would be nice.

@matthewbauer
Copy link
Member Author

Ok thanks! It's too bad bsdmake doesn't have an equivalent to that.

@matthewbauer matthewbauer deleted the bmake-compat branch May 6, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants