Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli: 1.14.50 -> 1.15.10; fix build #39678

Merged
merged 1 commit into from Apr 29, 2018
Merged

awscli: 1.14.50 -> 1.15.10; fix build #39678

merged 1 commit into from Apr 29, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 29, 2018 •
edited

Motivation for this change

As reported in #39676 the build broke because of ca52152 as the bump of
pythonPackages.botocore to 1.10.9 clashed with the wanted dependencies
in awscli.

In order to reduce the risk of accidental bugs because of loosened
version constraints I bumped the AWS CLI to 1.15.10 which depends on
botocore@1.10 as well.

Fixes #39676

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
awscli: 1.14.50 -> 1.15.10; fix build
0e5eafc 
As reported in NixOS#39676 the build broke because of ca52152 as the bump of
`pythonPackages.botocore` to 1.10.9 clashed with the wanted dependencies
in `awscli`.

In order to reduce the risk of accidental bugs because of loosened
version constraints I bumped the AWS CLI to `1.15.10` which depends on
`botocore@1.10` as well.

Fixes NixOS#39676
@Mic92
Copy link
Member

Mic92 commented Apr 29, 2018

@GrahamcOfBorg build awscli

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: awscli

Partial log (click to expand)

Successfully installed awscli-1.15.10
/build/awscli-1.15.10
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10/lib  /nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10/bin
patching script interpreter paths in /nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10
checking for references to /build in /nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10...
wrapping `/nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10/bin/aws'...
wrapping `/nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10/bin/aws_completer'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: awscli

Partial log (click to expand)

Successfully installed awscli-1.15.10
/build/awscli-1.15.10
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10/lib  /nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10/bin
patching script interpreter paths in /nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10
checking for references to /build in /nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10...
wrapping `/nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10/bin/aws'...
wrapping `/nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10/bin/aws_completer'...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: awscli

Partial log (click to expand)

Requirement already satisfied: six>=1.5 in /nix/store/vdf3cj4k3v84h8m1h4r6lxminl1h4icz-python2.7-six-1.11.0/lib/python2.7/site-packages (from python-dateutil<3.0.0,>=2.1; python_version >= "2.7"->botocore<=1.11,>=1.10.9->awscli==1.15.10)
Installing collected packages: awscli
Successfully installed awscli-1.15.10
/private/tmp/nix-build-awscli-1.15.10.drv-0/awscli-1.15.10
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/i5yclaq1m1a1z9dxg7b4aqj20c09qrff-awscli-1.15.10/lib  /nix/store/i5yclaq1m1a1z9dxg7b4aqj20c09qrff-awscli-1.15.10/bin
patching script interpreter paths in /nix/store/i5yclaq1m1a1z9dxg7b4aqj20c09qrff-awscli-1.15.10
wrapping `/nix/store/i5yclaq1m1a1z9dxg7b4aqj20c09qrff-awscli-1.15.10/bin/aws'...
wrapping `/nix/store/i5yclaq1m1a1z9dxg7b4aqj20c09qrff-awscli-1.15.10/bin/aws_completer'...

@xeji
Copy link
Contributor

xeji commented Apr 29, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: awscli

Partial log (click to expand)

/nix/store/72dr6hfp0cdpkwgkmr8da0l48cxfslwp-awscli-1.15.10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: awscli

Partial log (click to expand)

/nix/store/nik5dkhr5wd0sk2ncvjvf40y84790igf-awscli-1.15.10

@xeji xeji merged commit ff3fe10 into NixOS:master Apr 29, 2018
@Ma27 Ma27 deleted the fix-awscli branch April 29, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @Mic92 @GrahamcOfBorg @xeji