Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0e1147d13786
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 97adb03a9e54
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 29, 2018

  1. nixos/tests/predictable-interface-names: Refactor 

    The Nix expression here is really hard to read with multiple (and
unnecessarily) nested lets and it also generates attribute names based
on the derivation generated by makeTest, which will result in these
attribute names:

  * vm-test-run-predictableInterfaceNames
  * vm-test-run-predictableInterfaceNames-with-networkd
  * vm-test-run-unpredictableInterfaceNames
  * vm-test-run-unpredictableInterfaceNames-with-networkd

With the refactor the attribute names are now:

  * predictable
  * predictableNetworkd
  * unpredictable
  * unpredictableNetworkd

So now the code is even shorter and IMHO slightly more readable.

Signed-off-by: aszlig <aszlig@nix.build>
Cc: @symphorien, @fpletz, @adisbladis
    @aszlig
    aszlig committed Apr 29, 2018
    Copy the full SHA
    97adb03 View commit details
    Browse the repository at this point in the history