Mark .editorconfig as root #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
reviewed
Apr 30, 2018
| @@ -80,6 +80,8 @@ module Crystal | |||
| {"example", "example_app", "example-lib", "camel_example-camel_lib"}.each do |name| | |||
| describe_file "#{name}/.editorconfig" do |editorconfig| | |||
| parsed = INI.parse(editorconfig) | |||
| # TODO: remove comment out after next release | |||
There was a problem hiding this comment.
Why can't this be uncommentedf now?
There was a problem hiding this comment.
Sorry, I didn't understand Hash shape returned by INI.parse. I'll fix it.
straight-shoota
approved these changes
May 1, 2018
asterite
approved these changes
May 1, 2018
sdogruyol
approved these changes
May 1, 2018
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
.editorconfigin project root should setroot = trueand almost all projects do such. Why notcrystal-lang/crystaldo?