Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifi: introduce unifiTesting and upgrade unifiLTS and unifiStable #39705

Merged
merged 3 commits into from May 1, 2018
Merged

unifi: introduce unifiTesting and upgrade unifiLTS and unifiStable #39705

merged 3 commits into from May 1, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Regular package updates as well as making the test version available.

The suffix for the testing download can be obtained after signing up for their beta program. I haven't tried this package admittedly.

Cc: @badi @wkennington

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
unifi-testing: init at 5.8.14
9488756 
Also:
 - Instead of using a boolean flag to determine which package to build, use a
   generic builder
 - Add a few missing pre/post hooks
@peterhoeg
unifi-lts: 5.6.36 -> 5.6.37
a2f1d51
@peterhoeg
unifi-stable: 5.7.20 -> 5.7.23
c7fca25
@peterhoeg
Copy link
Member Author

peterhoeg commented Apr 30, 2018 •
edited

Forgot to mention - I find using callPackages with a generic builder far easier to maintain and read than using a boolean flag which obviously also limits the options to 2...

@badmutex
Copy link
Contributor

This is great!
If you'd like, I'm willing to test unifiStable and possible unifiTesting on my network and report back.

@peterhoeg
Copy link
Member Author

Please do.

@badmutex
Copy link
Contributor

badmutex commented May 1, 2018

No problems so far with unifiStable or unifiTesting.

@globin globin merged commit 9e37f7e into NixOS:master May 1, 2018
@peterhoeg peterhoeg deleted the u/unifi branch May 1, 2018 23:37
@peterhoeg peterhoeg restored the u/unifi branch May 2, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkennington wkennington Awaiting requested review from wkennington

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @badmutex @globin @GrahamcOfBorg