Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnunet: Add gnunet_git. #39672

Merged
merged 1 commit into from Apr 29, 2018
Merged

gnunet: Add gnunet_git. #39672

merged 1 commit into from Apr 29, 2018

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Apr 29, 2018

Motivation for this change

Gnunet didn't have a release in years but they are preparing a new one. Also they seem to have switched from svn to git for development, so I added a new git package. I tested nothing but the actual build and the start of a few binaries so far since gnunet is somewhat convoluted and I didn't manage to get it running with the old version. Going forward I'd like to add a pkg switch to the gnunet service and try to get that up to date for the next release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pstn
Copy link
Contributor Author

pstn commented Apr 29, 2018

Pinging @viric for easy access.

@viric viric merged commit 613e148 into NixOS:master Apr 29, 2018
@viric
Copy link
Member

viric commented Apr 29, 2018

I merge it, but please appoint yourself as maintainer. :)

@pstn
Copy link
Contributor Author

pstn commented Apr 29, 2018

Alright. Will do. Do you want to get rid of the entire gnunet maintainership? I think I understand the package enough to take over.

@pstn pstn deleted the gnunet-git branch April 29, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants